Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

[vuplus]: Fix URL-Enconding when adding timers #102

Merged
merged 1 commit into from

2 participants

@jdembski

Hi Lars,

this one fixes a bug in the vuplus addon.

If a user wants to create a timer on a channel with special characters, then this will currently fail as this part is not properly URL encoded. This fix adds the url encoding to this part of the URL...

@opdenkamp opdenkamp merged commit bef43bd into opdenkamp:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 3, 2012
  1. @jdembski
This page is out of date. Refresh to see the latest.
View
2  addons/pvr.vuplus/addon/addon.xml.in
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<addon
id="pvr.vuplus"
- version="1.6.3.4"
+ version="1.6.3.5"
name="VU+ / Enigma2 Client"
provider-name="Joerg Dembski">
<requires>
View
3  addons/pvr.vuplus/addon/changelog.txt
@@ -1,3 +1,6 @@
+0.3.5:
+- fix: URL encoding in timer-add operations
+
0.3.4:
- fix: several crashes on win32 due to missing locks / invalid memory access
- fix: do not report connection problems when there is an empty TV-channel bouquet
View
4 addons/pvr.vuplus/src/VuData.cpp
@@ -1407,9 +1407,9 @@ PVR_ERROR Vu::AddTimer(const PVR_TIMER &timer)
CStdString strServiceReference = m_channels.at(timer.iClientChannelUid-1).strServiceReference.c_str();
if (!g_strRecordingPath.compare(""))
- strTmp.Format("web/timeradd?sRef=%s&repeated=%d&begin=%d&end=%d&name=%s&description=%s&eit=%d&dirname=&s", strServiceReference, timer.iWeekdays, timer.startTime, timer.endTime, URLEncodeInline(timer.strTitle), URLEncodeInline(timer.strSummary),timer.iEpgUid, URLEncodeInline(g_strRecordingPath));
+ strTmp.Format("web/timeradd?sRef=%s&repeated=%d&begin=%d&end=%d&name=%s&description=%s&eit=%d&dirname=&s", URLEncodeInline(strServiceReference), timer.iWeekdays, timer.startTime, timer.endTime, URLEncodeInline(timer.strTitle), URLEncodeInline(timer.strSummary),timer.iEpgUid, URLEncodeInline(g_strRecordingPath));
else
- strTmp.Format("web/timeradd?sRef=%s&repeated=%d&begin=%d&end=%d&name=%s&description=%s&eit=%d", strServiceReference, timer.iWeekdays, timer.startTime, timer.endTime, URLEncodeInline(timer.strTitle), URLEncodeInline(timer.strSummary),timer.iEpgUid);
+ strTmp.Format("web/timeradd?sRef=%s&repeated=%d&begin=%d&end=%d&name=%s&description=%s&eit=%d", URLEncodeInline(strServiceReference), timer.iWeekdays, timer.startTime, timer.endTime, URLEncodeInline(timer.strTitle), URLEncodeInline(timer.strSummary),timer.iEpgUid);
CStdString strResult;
if(!SendSimpleCommand(strTmp, strResult))
Something went wrong with that request. Please try again.