Skip to content
This repository has been archived by the owner on Apr 15, 2023. It is now read-only.

Transcoding support for tvheadend #123

Merged
merged 17 commits into from Dec 28, 2012
Merged

Conversation

john-tornblom
Copy link
Contributor

This PR adds support for transcoding of streams when using my branch of tvheadend that supports transcoding: https://github.com/john-tornblom/tvheadend

There are a few things missing but I would like to get some feedback on the approach I've taken.

The feature makes use of menu hooks in order to configure the subscription requests. You can enable/disable transcoding, select audio/video codecs and choose a resolution. If the server doesn't support transcoding, the menu hook won't be added. Also, the codecs you can choose from is sent from the server so only valid ones will appear.

The problems right now is that I don't really know how to store the settings to settings.xml after the menu hook has been executed. Any ideas on how to do that?

@davilla
Copy link
Contributor

davilla commented Dec 23, 2012

ooo, nice

@nmaclean
Copy link

I am getting this error when trying to open the setting in xbmc.

17:30:55 T:140217872562048 DEBUG: POParser: loaded 15 strings from file /usr/local/share/xbmc/addons/pvr.hts/resources/language/English/strings.po
17:30:55 T:140217872562048 DEBUG: ------ Window Init (DialogSelect.xml) ------
17:30:55 T:140217872562048 INFO: Loading skin file: DialogSelect.xml, load type: KEEP_IN_MEMORY
17:30:55 T:140217872562048 DEBUG: Load DialogSelect.xml: 4.06ms
17:30:55 T:140217872562048 DEBUG: Alloc resources: 4.29ms (4.13 ms skin load)
17:30:55 T:140217872562048 DEBUG: Keyboard: scancode: 24, sym: 000d, unicode: 000d, modifier: 1000
17:30:55 T:140217872562048 DEBUG: OnKey: return (f00d) pressed, action is Select
17:30:55 T:140217872562048 DEBUG: ------ Window Deinit (DialogSelect.xml) ------
17:30:56 T:140217872562048 ERROR: Window_New: xbmc.pvrclient/Tvheadend HTSP Client - XML File '' for Window is missing, contact Developer 'Lars Op den Kamp, Team XBMC' of this AddOn
17:30:56 T:140217872562048 ERROR: Window_DoModal: xbmc.pvrclient/Tvheadend HTSP Client - No Window

@john-tornblom
Copy link
Contributor Author

xxxnelly, I had to manually copy the skin for the dialog into the confluence skin folder (DialogTranscode.xml)

@nmaclean
Copy link

Thanks - works now.

On 23 December 2012 18:03, John Törnblom notifications@github.com wrote:

xxxnelly, I had to manually copy the skin for the dialog into the
confluence skin folder (DialogTranscode.xml)


Reply to this email directly or view it on GitHubhttps://github.com//pull/123#issuecomment-11648697.

@opdenkamp
Copy link
Owner

nice indeed

we currently don't have any setters for those settings on the interface, only getters. so it's currently not possible to change settings from within the add-on.

@opdenkamp
Copy link
Owner

could you update the version to 1.6.6 and update the changelog (as in commit 6635349) and could you put "[tvheadend]" in front of all commit notes. thanks

@john-tornblom
Copy link
Contributor Author

Done. Note that changes made using the client specific dialog won't be saved on shutdown.

@opdenkamp
Copy link
Owner

sure, that's something for frodo+1

opdenkamp pushed a commit that referenced this pull request Dec 28, 2012
Transcoding support for tvheadend
@opdenkamp opdenkamp merged commit a04a5b3 into opdenkamp:master Dec 28, 2012
@Jonesi-y
Copy link

Jonesi-y commented Jan 4, 2013

Hi, is it possible to remap/transcode the audio channels in ACC? I get it in 5.1 but just want to have stereo. Thanks :)
LeonTV on iShit is badly not changing it :(
http://ip:9981/stream/channelid/185?mux=mpegts&transcode=1&resolution=384&acodec=ACC&vcodec=H264&scodec=NONE

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants