Skip to content

[tvheadend] fix instant recordings when channel has no epg data. #136

Merged
merged 2 commits into from Jan 5, 2013

2 participants

@nemphys
nemphys commented Jan 3, 2013

No description provided.

@opdenkamp opdenkamp commented on an outdated diff Jan 3, 2013
addons/pvr.hts/src/HTSPData.cpp
@@ -558,7 +558,7 @@ PVR_ERROR CHTSPData::AddTimer(const PVR_TIMER &timer)
htsmsg_t *msg = htsmsg_create_map();
htsmsg_add_str(msg, "method", "addDvrEntry");
- if ((GetProtocol() >= 6) && timer.iEpgUid)
+ if ((GetProtocol() >= 6) && timer.iEpgUid && timer.iEpgUid != -1)
@opdenkamp
Owner
opdenkamp added a note Jan 3, 2013
if ((GetProtocol() >= 6) && timer.iEpgUid > 0)

and you'll need to bump the add-on version and update the changelog for pvr.hts.

i'll create a development repos/branch for pvr.hts after frodo so we don't need to bump with every change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@nemphys
nemphys commented Jan 4, 2013

Done, please check.
As for the version bump, I saw in your last commit that you just update the change log file (which is what I also did), but not the addon.xml file (which still has 1.6.0 version). Is this the way to go?

@opdenkamp
Owner

ah! no, it's not, but i was stupid and edited addon.xml instead of addon.xml.in

could you update addon.xml.in please

@nemphys
nemphys commented Jan 4, 2013

there, should be ok now (separated the commits, too)

@nemphys
nemphys commented Jan 4, 2013

PS. I sometimes spot bugs here and there (eg. right now when I switch to an encrypted channel that can't be decrypted, I get disconnect/reconnect popups until I press stop); where can I submit them as bug reports (eg. somewhere you regularly check)?

@opdenkamp
Owner

yeah noticed it too. increasing the timeout from 10 to 15 secs will fix it. or make tvh send a notification a bit quicker than this.

you can create tickets for pvr.hts here

@opdenkamp opdenkamp merged commit 3b13e4c into opdenkamp:master Jan 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.