Only return an error when parsing of all events failed for a channel; return no error otherwise. #140

Merged
merged 2 commits into from Jan 7, 2013

Projects

None yet

2 participants

Contributor
nemphys commented Jan 5, 2013

fixes (harmless) errors introduced by 425a394

Owner

this doesn't look right either, since it'll return an unknown error for channels without epg data.

Contributor
nemphys commented Jan 5, 2013

No it won't; no epg data means goodEvents == failedEvents == 0, therefore (goodEvents == 0 && failedEvents > 0) returns false, so the initial PVR_NO_ERROR is returned.
Tested it, works fine

Owner

right ok, overlooked that one. could you change the error to PVR_ERROR_SERVER_ERROR instead of unknown, then i'll pull it in.

for future PR's (after frodo): create them for the pvr.hts branch instead, then we don't need to bump with each change.

Contributor
nemphys commented Jan 5, 2013

Done, please check

Contributor
nemphys commented Jan 6, 2013

Please merge this one, I have another one coming :-)

Owner

i've got other things to do than merging PRs, especially in the week ends, and spamming everybody who watches this repos with "please merge" certainly won't speed things up.

@opdenkamp opdenkamp merged commit 5631dc3 into opdenkamp:master Jan 7, 2013
Contributor
nemphys commented Jan 7, 2013

No need to be offensive, I've got other things to do, too; I am just trying to help here.

Owner

Helping out is fine, but there's no need to to remind me to merge something within 24 hours after your last update to the PR. Everybody who watches this repos or my github profile will get an email when you do, and there's no need to do that. I'll review every PR and won't delay merging any PR just for fun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment