New addon: pvr.iptvsimple #176

Merged
merged 1 commit into from Jun 9, 2013

Conversation

Projects
None yet
7 participants
@afedchin
Contributor

afedchin commented Feb 27, 2013

Hi Lars, this PR add PVR IPTV Simple addon for XBMC in official pvr addons tree.
Currently it support a channel list in m3u format with groups, icons and EPG in xmltv format.

I tested this addon on win32, linux(32 and 64), osx (32 and 64 bits), raspbmc, openelec and ios/atv. I think it shold work correctly on android also, but I can't test this.

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Mar 7, 2013

Owner

i'll review and test this asap

Owner

opdenkamp commented Mar 7, 2013

i'll review and test this asap

@dganic

This comment has been minimized.

Show comment Hide comment
@dganic

dganic Apr 1, 2013

opdenkamp, please find the time to check and approve. Thanks in advance!

dganic commented Apr 1, 2013

opdenkamp, please find the time to check and approve. Thanks in advance!

@manijak

This comment has been minimized.

Show comment Hide comment
@manijak

manijak Apr 16, 2013

Any news on this? Are we going to see this plugin in the offical pvr addon repo?
Thanks

manijak commented Apr 16, 2013

Any news on this? Are we going to see this plugin in the offical pvr addon repo?
Thanks

@cooliobr

This comment has been minimized.

Show comment Hide comment
@cooliobr

cooliobr May 6, 2013

Hi, any body here can compile an android version?, i try but not work

cooliobr commented May 6, 2013

Hi, any body here can compile an android version?, i try but not work

@afedchin

This comment has been minimized.

Show comment Hide comment
@afedchin

afedchin May 11, 2013

Contributor

@cooliobr, an android version can be compiled with xbmc together.

Contributor

afedchin commented May 11, 2013

@cooliobr, an android version can be compiled with xbmc together.

@cooliobr

This comment has been minimized.

Show comment Hide comment
@cooliobr

cooliobr May 11, 2013

ok, thanks...

ok, thanks...

@cooliobr

This comment has been minimized.

Show comment Hide comment
@cooliobr

cooliobr May 11, 2013

one more, how i can include iptvsimple in this source ?

one more, how i can include iptvsimple in this source ?

@afedchin

This comment has been minimized.

Show comment Hide comment
@afedchin

afedchin May 13, 2013

Contributor

@cooliobr, clone xbmc sources, change VERSION and BASE_URL into xbmc/tools/depends/target/xbmc-pvr-addons/Makefile to the current PR, and follow instructions to build for android,

Contributor

afedchin commented May 13, 2013

@cooliobr, clone xbmc sources, change VERSION and BASE_URL into xbmc/tools/depends/target/xbmc-pvr-addons/Makefile to the current PR, and follow instructions to build for android,

@cooliobr

This comment has been minimized.

Show comment Hide comment
@cooliobr

cooliobr May 13, 2013

i get this error
16:32:11 T:28225448 DEBUG: - registering add-on 'PVR IPTV Simple Client'
16:32:11 T:28225448 DEBUG: PVR - - creating PVR add-on instance 'PVR IPTV Simple Client'
16:32:11 T:28225448 DEBUG: ADDON: Dll Initializing - PVR IPTV Simple Client
16:32:11 T:28225448 DEBUG: SECTION:LoadDLL(/mnt/sdcard/Android/data/org.xbmc.xbmc/files/.xbmc/addons/pvr.iptvsimple/libXBMC_IPTV_Simple.so)
16:32:11 T:28225448 DEBUG: Loading: /mnt/sdcard/Android/data/org.xbmc.xbmc/files/.xbmc/addons/pvr.iptvsimple/libXBMC_IPTV_Simple.so
16:32:11 T:28225448 ERROR: Unable to load /mnt/sdcard/Android/data/org.xbmc.xbmc/files/.xbmc/addons/pvr.iptvsimple/libXBMC_IPTV_Simple.so, reason: (null)
16:32:11 T:28225448 INFO: Called Add-on status handler for '4' of clientName:PVR IPTV Simple Client, clientID:pvr.iptvsimple (same Thread=no)
16:32:11 T:28225448 WARNING: - failed to create add-on PVR IPTV Simple Client, status = 6
16:32:11 T:28225448 WARNING: - failed to load the dll for add-on PVR IPTV Simple Client, disabling it

i get this error
16:32:11 T:28225448 DEBUG: - registering add-on 'PVR IPTV Simple Client'
16:32:11 T:28225448 DEBUG: PVR - - creating PVR add-on instance 'PVR IPTV Simple Client'
16:32:11 T:28225448 DEBUG: ADDON: Dll Initializing - PVR IPTV Simple Client
16:32:11 T:28225448 DEBUG: SECTION:LoadDLL(/mnt/sdcard/Android/data/org.xbmc.xbmc/files/.xbmc/addons/pvr.iptvsimple/libXBMC_IPTV_Simple.so)
16:32:11 T:28225448 DEBUG: Loading: /mnt/sdcard/Android/data/org.xbmc.xbmc/files/.xbmc/addons/pvr.iptvsimple/libXBMC_IPTV_Simple.so
16:32:11 T:28225448 ERROR: Unable to load /mnt/sdcard/Android/data/org.xbmc.xbmc/files/.xbmc/addons/pvr.iptvsimple/libXBMC_IPTV_Simple.so, reason: (null)
16:32:11 T:28225448 INFO: Called Add-on status handler for '4' of clientName:PVR IPTV Simple Client, clientID:pvr.iptvsimple (same Thread=no)
16:32:11 T:28225448 WARNING: - failed to create add-on PVR IPTV Simple Client, status = 6
16:32:11 T:28225448 WARNING: - failed to load the dll for add-on PVR IPTV Simple Client, disabling it

@afedchin

This comment has been minimized.

Show comment Hide comment
@afedchin

afedchin May 14, 2013

Contributor

@cooliobr, this error appearing if you trying use the android version of the addon with the other xbmc compilation. I don't know why but on android you can use pvr addons only with xbmc which compiled with them.

Contributor

afedchin commented May 14, 2013

@cooliobr, this error appearing if you trying use the android version of the addon with the other xbmc compilation. I don't know why but on android you can use pvr addons only with xbmc which compiled with them.

@afedchin

This comment has been minimized.

Show comment Hide comment
@afedchin

afedchin May 17, 2013

Contributor

@opdenkamp, any news on this?

Contributor

afedchin commented May 17, 2013

@opdenkamp, any news on this?

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp May 17, 2013

Owner

yeah i wanted to include this in the last round, but didn't have time to do it. will include it next merge window

Owner

opdenkamp commented May 17, 2013

yeah i wanted to include this in the last round, but didn't have time to do it. will include it next merge window

@cooliobr

This comment has been minimized.

Show comment Hide comment
@cooliobr

cooliobr May 17, 2013

hi guys, is possible to put a user and pass form in iptvsimple ? if is possible to make a little change ? im using this stream http://5.135.193.159:9981/stream/channelid/14 test user is test and pass is test.

hi guys, is possible to put a user and pass form in iptvsimple ? if is possible to make a little change ? im using this stream http://5.135.193.159:9981/stream/channelid/14 test user is test and pass is test.

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp May 17, 2013

Owner

This looks very much like a stream from tvheadend. If so, just use pvr.hts

Op 17 mei 2013 om 18:28 heeft cooliobr notifications@github.com het volgende geschreven:

hi guys, is possible to put a user and pass form in iptvsimple ? if is possible to make a little change ? im using this stream http://5.135.193.159:9981/stream/channelid/14 test user is test and pass is test.


Reply to this email directly or view it on GitHub.

Owner

opdenkamp commented May 17, 2013

This looks very much like a stream from tvheadend. If so, just use pvr.hts

Op 17 mei 2013 om 18:28 heeft cooliobr notifications@github.com het volgende geschreven:

hi guys, is possible to put a user and pass form in iptvsimple ? if is possible to make a little change ? im using this stream http://5.135.193.159:9981/stream/channelid/14 test user is test and pass is test.


Reply to this email directly or view it on GitHub.

@cooliobr

This comment has been minimized.

Show comment Hide comment
@cooliobr

cooliobr May 17, 2013

but is not a tvheadend stream, is in icecast, tvheadend is main
server(brazil), but have onle 100mbps of uplink and my 3 slave
server(portugal, usa, germany) have 1gbps uplink
you can see here http://5.135.193.159:8000/, and icecast use a simple
httpauth,

2013/5/17 Lars Op den Kamp notifications@github.com

This looks very much like a stream from tvheadend. If so, just use pvr.hts

Op 17 mei 2013 om 18:28 heeft cooliobr notifications@github.com het
volgende geschreven:

hi guys, is possible to put a user and pass form in iptvsimple ? if is
possible to make a little change ? im using this stream http://
5.135.193.159:9981/stream/channelid/14 test user is test and pass is
test.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHubhttps://github.com/opdenkamp/xbmc-pvr-addons/pull/176#issuecomment-18073373
.

Att.

Rafael Machado
REGS Hospedagem de Sites e Soluções LTDA.
"Não existe patch para a estupidez humana"
"Nós somos o que pensamos (só não pense que você é um super-herói e não
tente voar)"

but is not a tvheadend stream, is in icecast, tvheadend is main
server(brazil), but have onle 100mbps of uplink and my 3 slave
server(portugal, usa, germany) have 1gbps uplink
you can see here http://5.135.193.159:8000/, and icecast use a simple
httpauth,

2013/5/17 Lars Op den Kamp notifications@github.com

This looks very much like a stream from tvheadend. If so, just use pvr.hts

Op 17 mei 2013 om 18:28 heeft cooliobr notifications@github.com het
volgende geschreven:

hi guys, is possible to put a user and pass form in iptvsimple ? if is
possible to make a little change ? im using this stream http://
5.135.193.159:9981/stream/channelid/14 test user is test and pass is
test.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHubhttps://github.com/opdenkamp/xbmc-pvr-addons/pull/176#issuecomment-18073373
.

Att.

Rafael Machado
REGS Hospedagem de Sites e Soluções LTDA.
"Não existe patch para a estupidez humana"
"Nós somos o que pensamos (só não pense que você é um super-herói e não
tente voar)"

@stefansaraev

This comment has been minimized.

Show comment Hide comment
@stefansaraev

stefansaraev May 27, 2013

Contributor

tested this addon (not the PR but https://github.com/afedchin/xbmc-addon-iptvsimple). confirmed working without issues at all with current Gotham master and Frodo (after reverting pvr-api to 1.6.0)

EDIT (offtopic): @afedchin would be nice if you rebase/squash it. generaly it's best to create a PR from separate branch to avoid including "merge commits"

Contributor

stefansaraev commented May 27, 2013

tested this addon (not the PR but https://github.com/afedchin/xbmc-addon-iptvsimple). confirmed working without issues at all with current Gotham master and Frodo (after reverting pvr-api to 1.6.0)

EDIT (offtopic): @afedchin would be nice if you rebase/squash it. generaly it's best to create a PR from separate branch to avoid including "merge commits"

@DiZet13

This comment has been minimized.

Show comment Hide comment
@DiZet13

DiZet13 Jun 5, 2013

@opdenkamp Hi. Any news on this one ? Will it be merged in June window?

DiZet13 commented Jun 5, 2013

@opdenkamp Hi. Any news on this one ? Will it be merged in June window?

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Jun 5, 2013

Owner

yes, i'll do some final checks asap and merge it in this window

Owner

opdenkamp commented Jun 5, 2013

yes, i'll do some final checks asap and merge it in this window

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Jun 7, 2013

Owner

couple of (minor) issues:

  • the PR must be rebased. there's merge commits in it now. squash the commits too please
  • you need to check for libz in configure.ac
  • this rapidxml thing looks like it's header-only. why are you creating a librapidxml.la from that?
Owner

opdenkamp commented Jun 7, 2013

couple of (minor) issues:

  • the PR must be rebased. there's merge commits in it now. squash the commits too please
  • you need to check for libz in configure.ac
  • this rapidxml thing looks like it's header-only. why are you creating a librapidxml.la from that?
@afedchin

This comment has been minimized.

Show comment Hide comment
@afedchin

afedchin Jun 7, 2013

Contributor

@opdenkamp, updated now.

Contributor

afedchin commented Jun 7, 2013

@opdenkamp, updated now.

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Jun 7, 2013

Owner

dependencies must be checked in the build_addons_with_dependencies part of configure.ac and should not be linked by specifying -lXXX in the makefile, but you should use what configure figured out instead, so things like -L or other flags that the dep needs are used.

i also just noticed an empty addons/pvr.iptvsimple/addon/iptv.m3u
what's this file doing? if this is some file that you update from within the add-on, then you'd have to change that, to use g_strUserPath instead and create a file there.

Owner

opdenkamp commented Jun 7, 2013

dependencies must be checked in the build_addons_with_dependencies part of configure.ac and should not be linked by specifying -lXXX in the makefile, but you should use what configure figured out instead, so things like -L or other flags that the dep needs are used.

i also just noticed an empty addons/pvr.iptvsimple/addon/iptv.m3u
what's this file doing? if this is some file that you update from within the add-on, then you'd have to change that, to use g_strUserPath instead and create a file there.

@afedchin

This comment has been minimized.

Show comment Hide comment
@afedchin

afedchin Jun 7, 2013

Contributor

@opdenkamp,
I haven't got enough experience in autoconfigure so I don't quite understand what needs to change in the configure.ac and makefile?

As for empty iptv.m3u this file is a placeholder and used for readonly if m3u path isn't set in the settings and can be used for a custom build. The addon doesn't change it in any way.

Contributor

afedchin commented Jun 7, 2013

@opdenkamp,
I haven't got enough experience in autoconfigure so I don't quite understand what needs to change in the configure.ac and makefile?

As for empty iptv.m3u this file is a placeholder and used for readonly if m3u path isn't set in the settings and can be used for a custom build. The addon doesn't change it in any way.

@afedchin

This comment has been minimized.

Show comment Hide comment
@afedchin

afedchin Jun 8, 2013

Contributor

updated.

Contributor

afedchin commented Jun 8, 2013

updated.

@opdenkamp

View changes

addons/pvr.iptvsimple/src/PVRIptvData.cpp
+ return NULL;
+}
+
+bool PVRIptvData::gzipInflate( const std::string& compressedBytes, std::string& uncompressedBytes ) {

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Jun 8, 2013

Owner

some cosmetics in this method. did you happen to c+p this from somewhere else? if so, what about copyright?

@opdenkamp

opdenkamp Jun 8, 2013

Owner

some cosmetics in this method. did you happen to c+p this from somewhere else? if so, what about copyright?

This comment has been minimized.

Show comment Hide comment
@afedchin

afedchin Jun 8, 2013

Contributor

Yes, it was c+p from toturial. Link is http://windrealm.org/tutorials/decompress-gzip-stream.php. I will add the copyrights.

@afedchin

afedchin Jun 8, 2013

Contributor

Yes, it was c+p from toturial. Link is http://windrealm.org/tutorials/decompress-gzip-stream.php. I will add the copyrights.

@opdenkamp

View changes

addons/pvr.iptvsimple/src/PVRIptvData.h
+ std::string strPlot;
+ std::string strIconPath;
+ std::string strGenreString;
+// time_t firstAired;

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Jun 8, 2013

Owner

could you remove commented out code from here. it's fine to have this in your own branch, but it's not nice to include it in here :)

@opdenkamp

opdenkamp Jun 8, 2013

Owner

could you remove commented out code from here. it's fine to have this in your own branch, but it's not nice to include it in here :)

+ virtual void *Process(void);
+
+private:
+ bool m_bTSOverride;

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Jun 8, 2013

Owner

cosmetics

@opdenkamp

opdenkamp Jun 8, 2013

Owner

cosmetics

@opdenkamp

View changes

addons/pvr.iptvsimple/src/PVRIptvData.h
+ PVRIptvData(void);
+ virtual ~PVRIptvData(void);
+
+ virtual int GetChannelsAmount(void);

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Jun 8, 2013

Owner

and more cosmetics down here. did you mix up tabs and spaces? jumps all over the place here ;-)

@opdenkamp

opdenkamp Jun 8, 2013

Owner

and more cosmetics down here. did you mix up tabs and spaces? jumps all over the place here ;-)

@opdenkamp

View changes

addons/pvr.iptvsimple/src/client.cpp
+ if (strResult.at(strResult.size() - 1) == '\\' ||
+ strResult.at(strResult.size() - 1) == '/')
+ {
+ strResult.append(strFileName);

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Jun 8, 2013

Owner

same here

@opdenkamp

opdenkamp Jun 8, 2013

Owner

same here

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Jun 8, 2013

Owner

could you fix up the cosmetics. i think you have your ide set up to use tabs instead of 2 spaces.
last request: move the rapidxml stuff into the /lib directory, since this is independent of the add-on and could be useful to other add-ons too.

if you fix this and address my concern about the gzinflate method, then i'll press the green button

Owner

opdenkamp commented Jun 8, 2013

could you fix up the cosmetics. i think you have your ide set up to use tabs instead of 2 spaces.
last request: move the rapidxml stuff into the /lib directory, since this is independent of the add-on and could be useful to other add-ons too.

if you fix this and address my concern about the gzinflate method, then i'll press the green button

@afedchin

This comment has been minimized.

Show comment Hide comment
@afedchin

afedchin Jun 8, 2013

Contributor

updated now.
I have fixed up the cosmetics, sync api changes and added the copyrights. As for gzinflate method see my comment before.

By the way 231f8de broke build in VC++. TARGET_WINDOW is not defined in VC++.

Contributor

afedchin commented Jun 8, 2013

updated now.
I have fixed up the cosmetics, sync api changes and added the copyrights. As for gzinflate method see my comment before.

By the way 231f8de broke build in VC++. TARGET_WINDOW is not defined in VC++.

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Jun 9, 2013

Owner

TARGET_WINDOWS has been added to the other projects by @fetzerch
please add it to this project too

Owner

opdenkamp commented Jun 9, 2013

TARGET_WINDOWS has been added to the other projects by @fetzerch
please add it to this project too

@afedchin

This comment has been minimized.

Show comment Hide comment
@afedchin

afedchin Jun 9, 2013

Contributor

updated.

Contributor

afedchin commented Jun 9, 2013

updated.

opdenkamp pushed a commit that referenced this pull request Jun 9, 2013

Lars Op den Kamp
Merge pull request #176 from afedchin/master
New addon: pvr.iptvsimple

@opdenkamp opdenkamp merged commit 771fa8b into opdenkamp:master Jun 9, 2013

+ PVR->TriggerChannelGroupsUpdate();
+ }
+
+ return;

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Jun 9, 2013

Owner

pretty sure it'll return without this statement, but let's not bitch about that ;-)

@opdenkamp

opdenkamp Jun 9, 2013

Owner

pretty sure it'll return without this statement, but let's not bitch about that ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment