Resubmit pvr.wmc addon to official pvr addons repo (Frodo branch) (squashed) #248

Merged
merged 3 commits into from Jan 2, 2014

Conversation

Projects
None yet
2 participants
@ryangribble
Contributor

ryangribble commented Dec 11, 2013

Similar to PR #247 for pvr.wmc addon into Gotham, this is the pvr.wmc addon incorporated into the frodo branch. I figured I may as well submit the PR for the frodo branch incase it can get in for Frodo 12.3 release. Otherwise we will just continue to use our repo's pvr.wmc_frodo branch to produce builds of this addon for frodo users

All the details provided in #247 are applicable here, with the exception that the Get/Set Resume support and SignalStatus support are deliberately not implemented in Frodo.

@ryangribble

This comment has been minimized.

Show comment Hide comment
@ryangribble

ryangribble Dec 11, 2013

Contributor

Updated and rebased, to remove strings.po files for unimplemented languages

Contributor

ryangribble commented Dec 11, 2013

Updated and rebased, to remove strings.po files for unimplemented languages

@ryangribble

This comment has been minimized.

Show comment Hide comment
@ryangribble

ryangribble Dec 17, 2013

Contributor

FRODO Commits tidied up, in line with comments/cleanup done in Gotham PR #247

Removed unused class
Removed _ GOTHAM_ preprocessor code
Split changes to pvr.wmc addon and changes in core xbmc_pvr_addons files, into separate commits

Contributor

ryangribble commented Dec 17, 2013

FRODO Commits tidied up, in line with comments/cleanup done in Gotham PR #247

Removed unused class
Removed _ GOTHAM_ preprocessor code
Split changes to pvr.wmc addon and changes in core xbmc_pvr_addons files, into separate commits

@ryangribble

This comment has been minimized.

Show comment Hide comment
@ryangribble

ryangribble Dec 18, 2013

Contributor

@opdenkamp , I'm not sure what the deal is with Frodo 12.3... Now that pvr.wmc addon is included in Gotham, is it possible to also have this Frodo branch pull request merged in, for Frodo 12.3?

Please let me know if anything is required

Contributor

ryangribble commented Dec 18, 2013

@opdenkamp , I'm not sure what the deal is with Frodo 12.3... Now that pvr.wmc addon is included in Gotham, is it possible to also have this Frodo branch pull request merged in, for Frodo 12.3?

Please let me know if anything is required

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Jan 2, 2014

Owner

it won't be included in the release, but i'll merge it in anyway

Owner

opdenkamp commented Jan 2, 2014

it won't be included in the release, but i'll merge it in anyway

opdenkamp pushed a commit that referenced this pull request Jan 2, 2014

Lars Op den Kamp
Merge pull request #248 from krustyreturns/pvr.wmc_frodo_squashed
Resubmit pvr.wmc addon to official pvr addons repo (Frodo branch) (squashed)

@opdenkamp opdenkamp merged commit 87dcf77 into opdenkamp:frodo Jan 2, 2014

@ryangribble ryangribble deleted the krustyreturns:pvr.wmc_frodo_squashed branch Mar 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment