[pvr.mythtv] Release v1.9.29: Critical fixes

[janbar]

Hi Lars,

Here you will find the set of critical fixes cherry-picked from master branch

• fixed some uninitialized values on MSVC
• fixed cache cleanup by max age
• fixed resource leak on file cache failure

br

[janbar]

I rebased to squash [pvr.mythtv] bugfixes.
Without those fixes Kodi die on OpenElec due to file handle leak (ulimit 1024).
I haven't feedback from android or ios users but same behavior is awaiting.

[janbar]

See thread http://forum.kodi.tv/showthread.php?tid=210104

[Jalle19]

@opdenkamp when should we start merging stuff normally again?

[opdenkamp]

best wait until the tag

[Jalle19]

AFAICT this fixes a pretty serious bug (open file descriptor limit reached), maybe we should just merge and let the RMs decide when to merge the bump? That way people can build their own addon in the mean time if necessary.

[opdenkamp]

Only crash & burn and 100% safe stuff goes in during RCs, and this did a
lot more than just fix that pretty serious bug when I checked this morning.

On 18-12-14 11:31, Sam Stenvall wrote:

AFAICT this fixes a pretty serious bug (open file descriptor limit
reached), maybe we should just merge and let the RMs decide when to
merge the bump? That way people can build their own addon in the mean
time if necessary.

—
Reply to this email directly or view it on GitHub
#393 (comment).

[Jalle19]

Well, running out of file descriptors pretty much crashes the entire computer. If @janbar makes a new PR with only that fix, would you merge that?

[opdenkamp]

sure, like I said, crash&burn is fine, but it did a lot more than that

On 18-12-14 12:32, Sam Stenvall wrote:

Well, running out of file descriptors pretty much crashes the entire
computer. If @janbar https://github.com/janbar makes a new PR with
only that fix, would you merge that?

—
Reply to this email directly or view it on GitHub
#393 (comment).

[Jalle19]

okay, so @janbar if you think the file descriptor fix is really important, create a new PR with just that and we can get that in right away. You can then rebase this one so it's ready for merging whenever the merge freeze is over.

[janbar]

@Jalle19 @opdenkamp i rebased and now cannot do less ;)

[barberio]

Just commenting because I don't think Janbar made it very clear. This PR was rebased to only include the critical bug fix, which is a crash&burn and wanted by OpenElec as a fix before release. A quick eyeball of the diffs says that it's only addressing this bug. Can you please review

[Jalle19]

I'm fine with it if @opdenkamp is.