Skip to content
This repository has been archived by the owner on Apr 15, 2023. It is now read-only.

TVH recordings additions #87

Merged
merged 2 commits into from Nov 30, 2012
Merged

Conversation

adamsutton
Copy link
Contributor

Added support for recordings being retrieved via HTSP (requires v7 server) rather than HTTP. This overcomes some of the limitations of HTTP in relation to in-progress recordings etc...

Added support for recordings folders (requires HTSP v7 capable server).

HTSP v7 is still WIP, but if anything changes I'll update.

@opdenkamp
Copy link
Owner

this broke seeking in recordings for me with tvheadend 3.2. didn't investigate

@adamsutton
Copy link
Contributor Author

@opdenkamp HTSPv6 seeking is now fixed. Also directory listing was incorrect, also fixed.

@opdenkamp
Copy link
Owner

30 second skip still doesn't work. it's also a lot slower than before this patch.

@adamsutton
Copy link
Contributor Author

@opdenkamp hmm, ok, I'll have another look.

@adamsutton
Copy link
Contributor Author

@opdenkamp I'm not seeing this, I am running a test server (built from release/3.2) and I have tested with pvr.hts before and after the change.

30s skip works fine in both cases and I don't see any difference in speed/performance.

I have double checked and the commit refs match those attached to the PR so I am not running the wrong version etc..

The only thing I'm seeing is performance for skipping via HTSP method (i.e. with new code) is not as good as I'd expect, I need to take a look at this.

@opdenkamp
Copy link
Owner

as discussed on irc, i won't merge this pr now because it doesn't fix or improve anything at the moment.

@adamsutton
Copy link
Contributor Author

@opdenkamp agreed, I think I've got to the bottom of the HTSP file serving problems I just need to implement a solution.

However I cannot repeat your problems with the mods against HTSPv6 server (i.e. HTTP streaming) the performance for me is identical pre/post these mods.

@adamsutton
Copy link
Contributor Author

@opdenkamp ok, that solves the skip performance problems. It does not however work (ff) with a couple of TVH recordings files I have, but as discussed on IRC I'm pretty sure this is a problem with the file and nothing to do with HTSP methods.

Using the same file via the old HTTP streaming OR direct file IO in XBMC does not work properly. (oh and VLC whines like made about it).

Using a decent file (i.e. a dvd->mkv/h264 rip) works just fine.

Can you take another look at the performance on your 3.2 TVH server as I cannot repeat what you mentioned, for me it works fine now.

opdenkamp pushed a commit that referenced this pull request Nov 30, 2012
@opdenkamp opdenkamp merged commit 3baf37e into opdenkamp:master Nov 30, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants