Show full screen video information even if stream isn't working #623

wants to merge 1 commit into

4 participants


Currently XBMC doesn't show info in fullscreen when a stream isn't playing (scrambled on satellite, not subscribed on iptv, ...) which is quite confusing. If you have a few non working channels one after another you can easily get confused on what should be currently playing.

This simple commit fixes that problem.


I am not sure if this is the right place for this check. Maybe it should go to CDVDPlayer::HasVideo(). Doing this it would most likely fix another problem: currently the background picture is shown when switching channels in minimized view.

@mikrohard mikrohard closed this Aug 24, 2012
@mikrohard mikrohard reopened this Aug 24, 2012

I tried as you suggested...

diff --git a/xbmc/cores/dvdplayer/DVDPlayer.cpp b/xbmc/cores/dvdplayer/DVDPlayer.cpp
index 4293a6e..9518550 100644
--- a/xbmc/cores/dvdplayer/DVDPlayer.cpp
+++ b/xbmc/cores/dvdplayer/DVDPlayer.cpp
@@ -2388,7 +2388,9 @@ bool CDVDPlayer::IsPaused() const

 bool CDVDPlayer::HasVideo() const
-  if (m_pInputStream && m_pInputStream->IsStreamType(DVDSTREAM_TYPE_DVD)) return true;
+  if (m_pInputStream && (m_pInputStream->IsStreamType(DVDSTREAM_TYPE_DVD) ||
+                         m_pInputStream->IsStreamType(DVDSTREAM_TYPE_PVRMANAGER)))
+    return true;

   return m_SelectionStreams.Count(STREAM_VIDEO) > 0 ? true : false;

It fixes the same problem as my initial patch. But the issue with the background picture in minimized view is still present.

But I can still update the pull request if everybody thinks it's better...

PS: Sorry for the close/reopen... it was an accidental click.


But the issue with the background picture in minimized view is still present

Hmm, I tried it and it does fix the issue that the background image which shows when switching channels.


unfortunately I don't remember why we did this a couple of months ago: 38fa2ee


Can't say i understand either.. I'd prefer if it was reverted if no good reason is found.


It seems that returning true in DVDPlayer::HasVideo() for all pvr manager streams would break visualizations in pvr radio channels...

Look at this: 52af67a
And then this: 63b4b09 (pull request #375)


finally I found our discussion: 52af67a#commitcomment-807350


yup, visualizations have been the trigger for this change: #375


Now that PVR support has been merged into mainline XBMC, every pull request must be sent as a pull request to mainline XBMC too:

That's why I am closing this one. Sorry for the trouble.

@opdenkamp opdenkamp closed this Sep 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment