Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrollable - Support React 17 #7

Closed
ykadosh opened this issue Dec 10, 2020 · 2 comments · Fixed by #32
Closed

Scrollable - Support React 17 #7

ykadosh opened this issue Dec 10, 2020 · 2 comments · Fixed by #32
Labels
released on @next released Scrollable

Comments

@ykadosh
Copy link
Collaborator

ykadosh commented Dec 10, 2020

React 17 introduced some breaking change to how events are propagated/bubbled, including changes to onScroll facebook/react#19464
This could be the reason why Scrollable doesn't work with React 17
gaeaehrlich added a commit to gaeaehrlich/webrix that referenced this issue May 2, 2021
@gaeaehrlich
fix(open-amdocs#7): Upgraded to React 17, including fix to Scrollable
9bf1d2d
@gaeaehrlich gaeaehrlich mentioned this issue May 2, 2021
Merged
@ykadosh ykadosh linked a pull request May 2, 2021 that will close this issue
Upgraded to React 17 with adjustments to Scrollable #32
Merged
gaeaehrlich added a commit to gaeaehrlich/webrix that referenced this issue May 2, 2021
@gaeaehrlich
fix(open-amdocs#7): Upgraded to React 17, including fix to Scrollable
736744f
gaeaehrlich added a commit to gaeaehrlich/webrix that referenced this issue May 3, 2021
@gaeaehrlich
fix(open-amdocs#7): Upgraded to React 17, including fix to Scrollable…
f2ec079 
… and effect cleanup timing
gaeaehrlich added a commit to gaeaehrlich/webrix that referenced this issue May 3, 2021
@gaeaehrlich
fix(open-amdocs#7): Upgraded to React 17, including fix to Scrollable…
10f05cc 
… and effect cleanup timing
gaeaehrlich added a commit to gaeaehrlich/webrix that referenced this issue May 3, 2021
@gaeaehrlich
fix(open-amdocs#7): Upgraded to React 17, including fix to Scrollable…
fd8db09 
… and effect cleanup timing
@ykadosh ykadosh closed this as completed May 4, 2021
@udia76
Copy link
Collaborator

udia76 commented May 4, 2021

🎉 This issue has been resolved in version 1.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@udia76 udia76 added the released label May 4, 2021
@udia76
Copy link
Collaborator

udia76 commented May 12, 2021

🎉 This issue has been resolved in version 1.3.0-next.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released on @next released Scrollable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgraded to React 17 with adjustments to Scrollable gaeaehrlich/webrix
2 participants
@ykadosh @udia76