Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throttle or debounce if those options are zero #90

Merged

Conversation

sbleon
Copy link
Contributor

@sbleon sbleon commented Nov 4, 2019

This allows the custom command to be run once for each path modified in a
single event, and resolves #71.

This allows the custom command to be run once for each path modified in a
single event, and resolves open-cli-tools#71.
@sbleon
Copy link
Contributor Author

@sbleon sbleon commented Nov 4, 2019

Other related PRs: #38, #52

@sbleon
Copy link
Contributor Author

@sbleon sbleon commented Nov 4, 2019

@paulmillr it looks like I'm the third person to attempt implementing this change/bugfix. Can you take a look? It's a pretty simple change.

Let me know if you need me to add tests for this.

@sbleon sbleon changed the title Don't throttle or debounce if those options were not specified. Don't throttle or debounce if those options are zero Nov 4, 2019
@paulmillr paulmillr merged commit 331243f into open-cli-tools:master Nov 5, 2019
1 check passed
@paulmillr
Copy link
Collaborator

@paulmillr paulmillr commented Nov 5, 2019

tests please yes

@sbleon
Copy link
Contributor Author

@sbleon sbleon commented Nov 5, 2019

@sbleon
Copy link
Contributor Author

@sbleon sbleon commented Nov 5, 2019

Test for this change is in #93.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants