Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command-${string}-formatted --success condition fails with dashes #324

Closed
eventualbuddha opened this issue May 20, 2022 · 4 comments · Fixed by #325
Closed

command-${string}-formatted --success condition fails with dashes #324

eventualbuddha opened this issue May 20, 2022 · 4 comments · Fixed by #325
Labels

Comments

@eventualbuddha
Copy link

@eventualbuddha eventualbuddha commented May 20, 2022

This should use the exit code from the first command (exit 1), but doesn't because the successCondition splits on -:

concurrently \
  --names 'this-one,that-one' \
  --success command-this-one \
  'exit 1' \
  'exit 0'

This version does work:

concurrently \
  --names 'this,that' \
  --success command-that \
  'exit 1' \
  'exit 0'
@gustavohenke
Copy link
Member

@gustavohenke gustavohenke commented May 20, 2022

Thanks for spotting this 🤦

@eventualbuddha
Copy link
Author

@eventualbuddha eventualbuddha commented May 20, 2022

Related, passing a command name that doesn't exist just silently ignores it. Maybe also true with indexes?

@paescuj
Copy link
Collaborator

@paescuj paescuj commented May 21, 2022

Related, passing a command name that doesn't exist just silently ignores it. Maybe also true with indexes?

Thanks for your input! We've discussed this in #318 (comment).

@gustavohenke
Copy link
Member

@gustavohenke gustavohenke commented May 22, 2022

Fix out in v7.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants