🐛 ignore hub apiserver override when forcing internal endpoint lookup #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… move hub CA to spec.hub Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TylerGillson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
TylerGillson
merged commit cc61b56
into
open-cluster-management-io:main
6 of 7 checks passed
arturshadnik
pushed a commit
to arturshadnik/ocm-labs
that referenced
this pull request
Jul 27, 2025
…open-cluster-management-io#34) * fix: ignore hub apiserver when force-internal-endpoint-lookup is set; move hub CA to spec.hub * feat: add timeout, verbosity to API; modernize applicable omitemptys * feat: add timeout, verbosity args to all clusteradm commands * fix: handle stdout & stderr separately * chore: fix 'make test' * ci: fix E2E artifact paths * fix: handle approval of duplicate CSRs --------- Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Jul 29, 2025
* 🐛 ignore hub apiserver override when forcing internal endpoint lookup (#34) * fix: ignore hub apiserver when force-internal-endpoint-lookup is set; move hub CA to spec.hub * feat: add timeout, verbosity to API; modernize applicable omitemptys * feat: add timeout, verbosity args to all clusteradm commands * fix: handle stdout & stderr separately * chore: fix 'make test' * ci: fix E2E artifact paths * fix: handle approval of duplicate CSRs --------- Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> * feat: implement addon enable/disable flow Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> * chore: add hub and spoke addon conditions Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> * feat: add validation to prevent deleting in-use addons Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> * test: add new expected condition Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> * wip: e2e test [skip ci] Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> * test: add e2e tests Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> * add docstrings; move code to helper to address gocyclo Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> * chore: trigger ci Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> * chore: trigger ci Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> * chore: demistify magic numbers Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> * feat: check number of MW against number of MCAO Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> * chore: helper for max type length Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> * fix: delete unused code Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> * chore: address review comments Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> * chore: update magic number; use ownerRef checks when deleting spoke Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> * fix: make unjoined check more robust Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> * chore: reorder checks Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> * chore: add unit tests; handle unknown conditions Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> --------- Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com> Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> Co-authored-by: Tyler Gillson <tyler.gillson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nil. Sometimes duplicate CSRs are created by the spoke registration agent when it gets bounced. Prior to this PR, fcc would only ever approve the 1st CSR, which subsequent klusterlet registration agents (post-bounce) don't care about.omitemptywithomitzero, per the modernize lintermake test-make test-unitwasn't outputting coverage results to the expected directory