Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove escalate bind rbac #344

Conversation

zhiweiyin318
Copy link
Member

No description provided.

@zhiweiyin318
Copy link
Member Author

/hold

@zhiweiyin318
Copy link
Member Author

/unhold

@zhiweiyin318
Copy link
Member Author

/assign @qiujian16

verbs: ["update"]
- apiGroups: ["work.open-cluster-management.io"]
resources: ["manifestworks"]
verbs: ["get", "list", "watch", "create", "update", "delete", "deletecollection", "patch", "execute-as"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need create verb for manifestworkreplicaset controller

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added


- apiGroups: ["addon.open-cluster-management.io"]
resources: ["managedclusteraddons"]
verbs: ["get", "list", "watch"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create/update/patch is also need for addon-manager controller

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@zhiweiyin318 zhiweiyin318 force-pushed the remove-rbac branch 11 times, most recently from ea3b883 to 13a14dd Compare April 13, 2023 06:07
@zhiweiyin318 zhiweiyin318 deleted the remove-rbac branch April 27, 2023 08:08
@zhiweiyin318 zhiweiyin318 restored the remove-rbac branch April 27, 2023 08:08
@zhiweiyin318 zhiweiyin318 reopened this Apr 27, 2023
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
@zhiweiyin318 zhiweiyin318 force-pushed the remove-rbac branch 3 times, most recently from 5797c87 to 32e685c Compare May 11, 2023 08:01
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [qiujian16,zhiweiyin318]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit fc16c67 into open-cluster-management-io:main May 11, 2023
8 checks passed
@zhiweiyin318 zhiweiyin318 deleted the remove-rbac branch May 11, 2023 08:32
zhiweiyin318 added a commit to zhiweiyin318/registration-operator that referenced this pull request May 15, 2023
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
zhiweiyin318 added a commit to zhiweiyin318/registration-operator that referenced this pull request May 15, 2023
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
zhiweiyin318 added a commit to zhiweiyin318/registration-operator that referenced this pull request May 15, 2023
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
zhiweiyin318 added a commit to zhiweiyin318/registration-operator that referenced this pull request May 15, 2023
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants