New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove escalate bind rbac #344
remove escalate bind rbac #344
Conversation
|
/hold |
50c453c
to
c6493ee
Compare
|
/unhold |
|
/assign @qiujian16 |
| verbs: ["update"] | ||
| - apiGroups: ["work.open-cluster-management.io"] | ||
| resources: ["manifestworks"] | ||
| verbs: ["get", "list", "watch", "create", "update", "delete", "deletecollection", "patch", "execute-as"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need create verb for manifestworkreplicaset controller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
|
|
||
| - apiGroups: ["addon.open-cluster-management.io"] | ||
| resources: ["managedclusteraddons"] | ||
| verbs: ["get", "list", "watch"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create/update/patch is also need for addon-manager controller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
ea3b883
to
13a14dd
Compare
13a14dd
to
edcc840
Compare
07a94d2
to
c481851
Compare
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
5797c87
to
32e685c
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fc16c67
into
open-cluster-management-io:main
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
No description provided.