Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding contextual logging #322

Conversation

Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
@openshift-ci openshift-ci bot requested review from mdelder and qiujian16 July 6, 2023 04:50
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nitishchauhan0022
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16
Copy link
Member

thanks for your work, since we've moved the code to ocm repo already, https://github.com/open-cluster-management-io/registration#note-do-not-edit-any-file-in-this-repo. would you create a PR in ocm repo instead?

@nitishchauhan0022
Copy link
Author

ok

@xuezhaojun
Copy link
Member

/assign @qiujian16
/assign @xuezhaojun

@xuezhaojun
Copy link
Member

/unassign @qiujian16
/unassign @xuezhaojun

@nitishchauhan0022
Copy link
Author

hey @xuezhaojun this pr need to be opened to the main ocm repo, and since that contains other components as well, so i will open a combined pr with 1-2 days for all components in that repo. Hope, you understand have not been geeting time to work on it.

@xuezhaojun
Copy link
Member

hey @xuezhaojun this pr need to be opened to the main ocm repo, and since that contains other components as well, so i will open a combined pr with 1-2 days for all components in that repo. Hope, you understand have not been geeting time to work on it.

Got it!Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants