fix Missing filter in issues#150 #151
Conversation
| @@ -48,6 +50,9 @@ func NewAppliedManifestWorkFinalizeController( | |||
| return factory.New(). | |||
| WithInformersQueueKeyFunc(func(obj runtime.Object) string { | |||
| accessor, _ := meta.Accessor(obj) | |||
| if !strings.HasPrefix(accessor.GetName(), hubHash) { | |||
| return "" | |||
There was a problem hiding this comment.
we have a queueKeyFunc in helper that you can use. Also I think we should use WithFilteredInformersQueueKeyFunc
There was a problem hiding this comment.
Is the queueKeyFunc in helper this func？
Line 322 in 8f20697
This func will return a manifestwork key, but in this controller we need a appliedmanifestwork key. May I can provide another func in helper?
There was a problem hiding this comment.
ok, that will be great. And maybe also a filter func in helper that can be reused by multiple controllers.
There was a problem hiding this comment.
ok, that will be great. And maybe also a filter func in helper that can be reused by multiple controllers.
The changes have been committed
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, TYTaO The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: tytao <1522014784@qq.com>
|
/lgtm |
Use hubHash to distinguish resources like other controllers