Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we remove make_field_definitions.py #506

Closed
timgdavies opened this issue Jul 22, 2017 · 2 comments
Closed

Can we remove make_field_definitions.py #506

timgdavies opened this issue Jul 22, 2017 · 2 comments
Assignees
@timgdavies
Milestone
1.1.1

Comments

@timgdavies
Copy link
Contributor

I believe make_field_definitions.py is no longer used in the build process, as our new sphinx directive removes the need to rely on intermediate CSV files.

However, it is still present in the builds scripts and babel process.

@Bjwebb Is it safe to remove this in the 1.1.1?
@timgdavies timgdavies added this to the Version 1.1.1 - Bugfixes milestone Jul 22, 2017
@jpmckinney jpmckinney mentioned this issue Jul 22, 2017
Merged
@Bjwebb
Copy link
Contributor

Bjwebb commented Jul 24, 2017

Yes, should be safe to remove this.

@timgdavies timgdavies assigned timgdavies and unassigned Bjwebb Jul 24, 2017
@timgdavies
Copy link
Contributor Author

Ok. I'll do that shortly.

jpmckinney pushed a commit that referenced this issue Jul 24, 2017
Fix merge after #505 and #506
d6d9d71
This was referenced Jul 31, 2017
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timgdavies timgdavies

Labels
None yet
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
2 participants
@Bjwebb @timgdavies