Update prometheus role to increase nofile limit for service #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m change with the fix comes with a lot of other changes that we can't apply right now. This will override the prometheus systemd unit to apply this limit without editing the existing file.
|
@xitij2000 I think this is related to #210 |
giovannicimolin
approved these changes
May 4, 2021
There was a problem hiding this comment.
👍
- I tested this:
- Added a tag to the extra task.
- Ran the playbooks with the specific tag.
- Checked that the configuration was deployed to the prometheus server.
- I read through the code
- I checked for accessibility issues
- Includes documentation
@xitij2000 LGTM.
It does, but my understanding is that PR can't merge for quite some time till we upgrade other parts of our infrastructure. This can solve the issue for now, and we can remove this patch when the other PR merges. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default nofile limit for prometheus is quite low, and the upstream change with the fix comes with a lot of other changes that we can't apply right now.
This will override the prometheus systemd unit to apply this limit without editing the existing file.