Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCKIN-24633 master PR for portuguese translation isssue #302

Merged
merged 2 commits into from
Sep 22, 2020

Conversation

mudassir-hafeez
Copy link
Contributor

Jira ticket https://edx-wiki.atlassian.net/browse/MCKIN-24633
this PR keeps up to date master for #301

@mudassir-hafeez
Copy link
Contributor Author

@shimulch here is the same as #301. I know v3 release will work against us, but we also release the same code changes against master. Just wanted to give a reminder.

Copy link

@shimulch shimulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

  • I tested this: Ran tests locally
  • I read through the code
    - [ ] I checked for accessibility issues
    - [ ] Includes documentation
    - [ ] I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@shimulch shimulch merged commit 264be99 into open-craft:master Sep 22, 2020
@shimulch
Copy link

Released v4.1.2

musmanmalik added a commit to musmanmalik/problem-builder that referenced this pull request Sep 23, 2020
MCKIN-24633 master PR for portuguese translation isssue (open-craft#302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants