Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run nix-build in CI #6

Merged
merged 2 commits into from
Jan 21, 2020
Merged

Run nix-build in CI #6

merged 2 commits into from
Jan 21, 2020

Conversation

srid
Copy link
Contributor

@srid srid commented Jan 20, 2020

I think cachix-action runs it only when there is push access to the cache. There isn't one in this repo, so I guess that's why it is not running nix-build. In any case, it is better to run it explicitly.

Let's wait and see if the CI for this PR in fact runs nix-build.

I think `cachix-action` runs it only when there is push access to the cache. There isn't one in this repo, so I guess that's why it is not running nix-build. In any case, it is better to run it explicitly.

Let's wait and see if the CI for this PR in fact runs nix-build.
Just wanted to see if this works.
@srid
Copy link
Contributor Author

srid commented Jan 20, 2020

Looks like this worked. See "Build" step in https://github.com/open-editions/open-editions.org/pull/6/checks?check_run_id=399770931

@JonathanReeve
Copy link
Member

Awesome! Does this mean I can remove dist/ and just have netlify serve the built result? Is that in result/?

@JonathanReeve JonathanReeve merged commit 24acf89 into open-editions:master Jan 21, 2020
@srid
Copy link
Contributor Author

srid commented Jan 21, 2020

Does this mean I can remove dist/ and just have netlify serve the built result?

With a few more steps, yes. You can run $(nix-build)/bin/open-editions-org generate --full as a step and then use the netlify Github Action (linked from here) to push the resultant ./dist directory. That might work, but I've never worked with netlify. It is worth a try I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants