Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LibDigiDocpp dependency versioned #409

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Dec 10, 2018

Fixes #408

cc @metsma

@glensc
Copy link
Contributor Author

glensc commented Dec 10, 2018

For this to work libdigidocpp.pc needs to provide Version:

For me it's empty:

➔ cat /usr/lib64/pkgconfig/libdigidocpp.pc
prefix=/usr
exec_prefix=/usr/bin
libdir=/usr/lib64
includedir=/usr/include

Name: libdigidocpp
Description: Libdigidocpp C++ library for handling digitally signed documents
Version:
Libs: -L${libdir} -ldigidocpp
Cflags: -I${includedir}

The used DIGIDOCPP_VERSION macro doesn't seem to be defined in libdigidocpp:

[~/rpm/packages/BUILD.x86_64-linux/libdigidocpp-3.13.8(3.8)] ➔ rgrep -r DIGIDOCPP_VERSION .
./etc/Doxyfile.in:41:PROJECT_NUMBER         = @DIGIDOCPP_VERSION@
./src/libdigidocpp.pc.cmake:8:Version: @DIGIDOCPP_VERSION@
[~/rpm/packages/BUILD.x86_64-linux/libdigidocpp-3.13.8(3.8)] ➔

@glensc
Copy link
Contributor Author

glensc commented Dec 10, 2018

looks like DIGIDOCPP_VERSION was never defined in the project.

at least the initial commit in git repo already has it unreferenced. i suppose the svn history is not available?

@metsma
Copy link
Contributor

metsma commented Dec 10, 2018

@metsma
Copy link
Contributor

metsma commented Dec 10, 2018

@glensc glensc changed the title WIP: Make LibDigiDocpp dependency versioned Make LibDigiDocpp dependency versioned Dec 10, 2018
@glensc
Copy link
Contributor Author

glensc commented Dec 10, 2018

hmm. it's not fatal error even the version is not satisfied:

-- Found LibDigiDocpp: /usr/lib64/libdigidocpp.so (Required is at least version "3.13.9")
...
➔ grep Ver /usr/lib64/pkgconfig/libdigidocpp.pc
Version: 3.13.8

glensc added a commit to pld-linux/digidoc4-client that referenced this pull request Dec 10, 2018
@metsma metsma self-requested a review December 17, 2018 14:00
@iannaska iannaska merged commit b7ffbb9 into open-eid:master Jan 10, 2019
@glensc glensc deleted the LibDigiDocpp-required branch January 14, 2019 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants