Skip to content

Add NeuropixelsV2e GUI documentation #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 28, 2024
Merged

Add NeuropixelsV2e GUI documentation #52

merged 3 commits into from
Aug 28, 2024

Conversation

@bparks13
Copy link
Member

@bparks13 bparks13 commented Aug 26, 2024 •
edited by jonnew
Loading

Adding a tutorial for how to use the NeuropixelsV2e GUI.

Closes #41
Closes #49

@bparks13 bparks13 requested review from cjsha and jonnew August 26, 2024 18:59
@bparks13 bparks13 self-assigned this Aug 26, 2024
cjsha
cjsha reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@cjsha cjsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this great. My comments are mostly nitpicks

@jonnew jonnew mentioned this pull request Aug 27, 2024
Closed
@cjsha cjsha self-requested a review August 27, 2024 22:05
bparks13 and others added 2 commits August 28, 2024 11:26
@bparks13
Address review comments
adbe2bd
@cjsha
Add instructions to install OpenEphys.Onix1.Design
1d8ca57 
- Add screenshot
- Remove part about installing OpenEphys.Onix1 bc it's redundant now
cjsha
cjsha approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@cjsha cjsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I will say that it does feel long, but I think it's good to get all this material out. If others agree that it feels long, we can try trimming it later when reorganizing content per issue #40

@bparks13
Copy link
Member Author

bparks13 commented Aug 28, 2024

Agreed that it's a bit long, might be worth chopping it up and putting into specific pages, as per our discussions. We can revisit this when we start reorganizing the structure of the docs.

@bparks13 bparks13 merged commit bb03b04 into main Aug 28, 2024
@bparks13 bparks13 deleted the issue-41-npx2e-gui branch August 28, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjsha cjsha cjsha approved these changes

@jonnew jonnew Awaiting requested review from jonnew

Assignees

@bparks13 bparks13

Labels

None yet

Projects

None yet

Milestone

Document Neuropixels GUIs

Development

Successfully merging this pull request may close these issues.

Add a way in the template to center images? Create documentation page for NeuropixelsV2e GUI

3 participants

@bparks13 @cjsha