Refactor Rhs2116 to save ProbeInterface files externally #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aacuevas
approved these changes
Nov 17, 2025
Collaborator
aacuevas
left a comment
aacuevas
left a comment
There was a problem hiding this comment.
Same pattern as already implemented on other similar classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #522, this PR no longer saves the ProbeInterface configuration directly in the Bonsai file. Now, there is a
ProbeInterfaceFileNameproperty that points to where the file will be saved/loaded.The file is only saved when the Bonsai file itself is saved (during serialization). The file is then lazily loaded when the Bonsai file itself is loaded. This allows the workflow to load fully before checking if there were any errors during initialization.
Fixes #547