Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Flagsmith provider #89

Merged
merged 13 commits into from
Oct 24, 2023
Merged

feat: Add Flagsmith provider #89

merged 13 commits into from
Oct 24, 2023

Conversation

vpetrusevici
Copy link
Contributor

@vpetrusevici vpetrusevici commented Oct 18, 2023 •
edited
Loading

This PR

Adds a library project for Flagsmith provider with implementation and tests

Related Issues

#90
Flagsmith/flagsmith-dotnet-client#78

Notes

We are going to use OpenFeature and Flagsmith in our projects. Unfortunately dotnet-sdk-contrib doesn't have Flagsmith provider, so i implemented it.

Follow-up Tasks

  • Implement
  • Add unit tests for general funcations
  • Add unit tests for using OpenFeature evaluation context
  • Review from Flagsmith team

How to test

Just create FlagsmithProvider using FlagsmithClient or FlagsmithConfiguration according to https://github.com/Flagsmith/flagsmith-dotnet-client/tree/main/Example

@vpetrusevici vpetrusevici requested a review from a team as a code owner October 18, 2023 13:05
@vpetrusevici vpetrusevici mentioned this pull request Oct 18, 2023
Closed
@vpetrusevici vpetrusevici changed the title Add Flagsmith provider feat: Add Flagsmith provider Oct 18, 2023
@beeme1mr
Copy link
Member

Hey @dabeeeenster, could someone from the Flagsmith team please take a look when you have a moment?

@toddbaert toddbaert self-requested a review October 18, 2023 18:42
toddbaert
toddbaert requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this addition! I made a few comments, but this looks like a great addition!

I'm marking as "request changes" for now, primarily because I'd like an approval from a representative from Flagsmith first.

Once we have identified a Flagsmith representative, I will add you and them to https://github.com/open-feature/dotnet-sdk-contrib/blob/main/.github/component_owners.yml as part of this PR.

@toddbaert toddbaert mentioned this pull request Oct 18, 2023
Closed
5 tasks
@vpetrusevici vpetrusevici reopened this Oct 18, 2023
vpetrusevici and others added 4 commits October 23, 2023 14:22
@vpetrusevici @matthewelwell
Apply suggestions from code review
9c9eda9 
Co-authored-by: Matthew Elwell <mjelwell89@gmail.com>
Signed-off-by: vpetrusevici <vladimir.petrusevici@outlook.com>
Signed-off-by: Vladimir Petrusevici <vladimir.petrusevici@outlook.com>
@vpetrusevici
Add config to enable boolean value
419a55f 
Signed-off-by: Vladimir Petrusevici <vladimir.petrusevici@outlook.com>
@vpetrusevici
fix tests
635cfc9 
Signed-off-by: Vladimir Petrusevici <vladimir.petrusevici@outlook.com>
@vpetrusevici
add provider configuration in a separate class
0a53954 
Signed-off-by: Vladimir Petrusevici <vladimir.petrusevici@outlook.com>
@vpetrusevici
Copy link
Contributor Author

Hi @beeme1mr,
Do we need anything else?

matthewelwell
matthewelwell approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a Flagsmith perspective.

beeme1mr
beeme1mr reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had one question about the icon, but the rest looks good. @toddbaert, did you have any other concerns?

Before we merge, could you lease update the component_owners.yml to include @matthewelwell, novakzaballa, and yourself?

src/OpenFeature.Contrib.Providers.Flagsmith/openfeature-icon.png Outdated Show resolved Hide resolved
@vpetrusevici
add owners and remove unnecessary image
5fb0781 
Signed-off-by: Vladimir Petrusevici <vladimir.petrusevici@outlook.com>
@vpetrusevici
Copy link
Contributor Author

I just had one question about the icon, but the rest looks good. @toddbaert, did you have any other concerns?

Before we merge, could you lease update the component_owners.yml to include @matthewelwell, novakzaballa, and yourself?

done

@beeme1mr
Copy link
Member

Could you please also add a readme under src/OpenFeature.Contrib.Providers.Flagsmith/? It should have installation instructions and usage examples. Sorry, I didn't notice that it was missing in my last review!

@vpetrusevici
add readme
79adc12 
Signed-off-by: Vladimir Petrusevici <vladimir.petrusevici@outlook.com>
@vpetrusevici
Copy link
Contributor Author

Could you please also add a readme under src/OpenFeature.Contrib.Providers.Flagsmith/? It should have installation instructions and usage examples. Sorry, I didn't notice that it was missing in my last review!

I just copied readme form flagd provider and adapted to Flagsmith provider.

beeme1mr
beeme1mr approved these changes Oct 24, 2023
View reviewed changes
src/OpenFeature.Contrib.Providers.Flagsmith/README.md Outdated Show resolved Hide resolved
src/OpenFeature.Contrib.Providers.Flagsmith/README.md Outdated Show resolved Hide resolved
src/OpenFeature.Contrib.Providers.Flagsmith/README.md Outdated Show resolved Hide resolved
vpetrusevici and others added 3 commits October 24, 2023 09:06
@vpetrusevici @beeme1mr
Update src/OpenFeature.Contrib.Providers.Flagsmith/README.md
901fe26 
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: vpetrusevici <vladimir.petrusevici@outlook.com>
@vpetrusevici @beeme1mr
Update src/OpenFeature.Contrib.Providers.Flagsmith/README.md
741be47 
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: vpetrusevici <vladimir.petrusevici@outlook.com>
@vpetrusevici @beeme1mr
Update src/OpenFeature.Contrib.Providers.Flagsmith/README.md
0591b39 
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: vpetrusevici <vladimir.petrusevici@outlook.com>
@vpetrusevici
Copy link
Contributor Author

@toddbaert can we complete the PR? :)

@toddbaert toddbaert self-requested a review October 24, 2023 18:21
toddbaert
toddbaert approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vpetrusevici very nice! I like the delegate implementation. This is a great addition!

I'm approving but you have some minor formatting issues (you should be able to test your fixes with dotnet-format --folder --check). I'll keep an eye on the PR and re-run the checks / merge as soon as they pass.

@vpetrusevici
Formatting
ac4c482 
Signed-off-by: Vladimir Petrusevici <vladimir.petrusevici@outlook.com>
@vpetrusevici
Merge branch 'develop' of https://github.com/vpetrusevici/open-featur…
24fdc38 
…e-dotnet-sdk-contrib into develop
@vpetrusevici
Copy link
Contributor Author

vpetrusevici commented Oct 24, 2023 •
edited
Loading

@vpetrusevici very nice! I like the delegate implementation. This is a great addition!

I'm approving but you have some minor formatting issues (you should be able to test your fixes with dotnet-format --folder --check). I'll keep an eye on the PR and re-run the checks / merge as soon as they pass.

I added #pragma warning disable format for json in tests. it's strange but dotnet-format tries to fix this string...

@toddbaert toddbaert merged commit b7ba62e into open-feature:main Oct 24, 2023
9 checks passed
@github-actions github-actions bot mentioned this pull request Oct 24, 2023
Merged
@toddbaert toddbaert mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@matthewelwell matthewelwell matthewelwell approved these changes

@toddbaert toddbaert toddbaert approved these changes

@bacherfl bacherfl Awaiting requested review from bacherfl

@dabeeeenster dabeeeenster Awaiting requested review from dabeeeenster

@thomaspoignant thomaspoignant Awaiting requested review from thomaspoignant

Assignees

@bacherfl bacherfl

@matthewelwell matthewelwell

@thomaspoignant thomaspoignant

@toddbaert toddbaert

@vpetrusevici vpetrusevici

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vpetrusevici @beeme1mr @matthewelwell @toddbaert @bacherfl @thomaspoignant