Skip to content

ci(flagd): remove sync server as it is part of flagd by now #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 26, 2024
Merged

ci(flagd): remove sync server as it is part of flagd by now #1080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2eb55e8
ci(flagd): remove sync server as it is part of flagd by now
aepfli Nov 22, 2024
3ed5b24
fixup: changing ports in doc and envoy
aepfli Nov 22, 2024
4a6c46f
Merge branch 'main' into ci/flagd-remove-sync-server
aepfli Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ders/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/ContainerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@ public static GenericContainer sync() {
/**
*
* @param unstable if an unstable version of the container, which terminates the connection regularly should be used.
* @param addNetwork if set to true a custom network is attached for cross container access e.g. envoy --> sync:9090
* @return a {@link org.testcontainers.containers.GenericContainer} instance of a sync flagd server with the port 9090 exposed
* @param addNetwork if set to true a custom network is attached for cross container access e.g. envoy --> sync:8015
* @return a {@link org.testcontainers.containers.GenericContainer} instance of a sync flagd server with the port 8015 exposed
*/
public static GenericContainer sync(boolean unstable, boolean addNetwork) {
String container = generateContainerName("sync", unstable);
String container = generateContainerName("flagd", unstable);
GenericContainer genericContainer = new GenericContainer(DockerImageName.parse(container))
.withExposedPorts(9090);
.withExposedPorts(8015);

if (addNetwork) {
genericContainer.withNetwork(network);
Expand Down
2 changes: 1 addition & 1 deletion providers/flagd/src/test/resources/envoy-config/envoy-custom.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,4 @@ static_resources:
address:
socket_address:
address: sync-service
port_value: 9090
port_value: 8015