From 5cc5bd14dc0d8c5a8f8282443864b479471c41dd Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 21 Nov 2025 19:43:38 +0000 Subject: [PATCH 1/3] chore(deps): update dependency com.github.spotbugs:spotbugs to v4.9.8 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index bb992a020..57eeac166 100644 --- a/pom.xml +++ b/pom.xml @@ -117,7 +117,7 @@ com.github.spotbugs spotbugs - 4.8.6 + 4.9.8 provided @@ -467,7 +467,7 @@ com.github.spotbugs spotbugs - 4.9.0 + 4.9.8 From 0761c0afe6dbcc2cc0aad9488daed10703d04ea5 Mon Sep 17 00:00:00 2001 From: Simon Schrottner Date: Fri, 21 Nov 2025 21:08:22 +0100 Subject: [PATCH 2/3] fixup: removing unneeded supressions Signed-off-by: Simon Schrottner --- .../flagd/resolver/common/QueueingStreamObserver.java | 2 +- .../providers/flagd/resolver/process/model/FlagParser.java | 4 ---- .../process/storage/connector/sync/SyncStreamQueueSource.java | 2 +- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/common/QueueingStreamObserver.java b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/common/QueueingStreamObserver.java index 435a7be18..17c01a15c 100644 --- a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/common/QueueingStreamObserver.java +++ b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/common/QueueingStreamObserver.java @@ -10,7 +10,7 @@ */ @Slf4j @SuppressFBWarnings( - value = {"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}, + value = {"EI_EXPOSE_REP"}, justification = "Internal class") public class QueueingStreamObserver implements StreamObserver { private final BlockingQueue> blockingQueue; diff --git a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/model/FlagParser.java b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/model/FlagParser.java index 2b109ccb9..ee456e31a 100644 --- a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/model/FlagParser.java +++ b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/model/FlagParser.java @@ -9,7 +9,6 @@ import com.networknt.schema.JsonSchemaFactory; import com.networknt.schema.SpecVersion; import com.networknt.schema.ValidationMessage; -import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import java.io.IOException; import java.net.URI; import java.util.HashMap; @@ -23,9 +22,6 @@ /** flagd feature flag configuration parser. */ @Slf4j -@SuppressFBWarnings( - value = {"EI_EXPOSE_REP"}, - justification = "Feature flag comes as a Json configuration, hence they must be exposed") public class FlagParser { private static final String FLAG_KEY = "flags"; private static final String METADATA_KEY = "metadata"; diff --git a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/connector/sync/SyncStreamQueueSource.java b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/connector/sync/SyncStreamQueueSource.java index 196ab77a6..a3b01f913 100644 --- a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/connector/sync/SyncStreamQueueSource.java +++ b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/connector/sync/SyncStreamQueueSource.java @@ -32,7 +32,7 @@ */ @Slf4j @SuppressFBWarnings( - value = {"PREDICTABLE_RANDOM", "EI_EXPOSE_REP"}, + value = {"EI_EXPOSE_REP"}, justification = "Random is used to generate a variation & flag configurations require exposing") public class SyncStreamQueueSource implements QueueSource { private static final int QUEUE_SIZE = 5; From 40d5326063c661a0e9c070df61a57b5f279d07af Mon Sep 17 00:00:00 2001 From: Simon Schrottner Date: Fri, 21 Nov 2025 21:08:22 +0100 Subject: [PATCH 3/3] fixup: removing unneeded supressions Signed-off-by: Simon Schrottner --- .../FlagsmithProviderOptions.java | 2 +- .../storage/connector/sync/http/HttpConnectorOptions.java | 2 +- .../storage/connector/sync/http/PayloadCacheOptions.java | 4 ---- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/providers/flagsmith/src/main/java/dev.openfeature.contrib.providers.flagsmith/FlagsmithProviderOptions.java b/providers/flagsmith/src/main/java/dev.openfeature.contrib.providers.flagsmith/FlagsmithProviderOptions.java index c991496d8..64a4d9af0 100644 --- a/providers/flagsmith/src/main/java/dev.openfeature.contrib.providers.flagsmith/FlagsmithProviderOptions.java +++ b/providers/flagsmith/src/main/java/dev.openfeature.contrib.providers.flagsmith/FlagsmithProviderOptions.java @@ -15,7 +15,7 @@ /** FlagsmithProviderOptions contains the options to initialise the Flagsmith provider. */ @SuppressFBWarnings( - value = {"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}, + value = {"EI_EXPOSE_REP"}, justification = "The headers need to be mutable") @Builder(toBuilder = true) @Getter diff --git a/tools/flagd-http-connector/src/main/java/dev/openfeature/contrib/tools/flagd/resolver/process/storage/connector/sync/http/HttpConnectorOptions.java b/tools/flagd-http-connector/src/main/java/dev/openfeature/contrib/tools/flagd/resolver/process/storage/connector/sync/http/HttpConnectorOptions.java index 9437f7f1d..32d993ea9 100644 --- a/tools/flagd-http-connector/src/main/java/dev/openfeature/contrib/tools/flagd/resolver/process/storage/connector/sync/http/HttpConnectorOptions.java +++ b/tools/flagd-http-connector/src/main/java/dev/openfeature/contrib/tools/flagd/resolver/process/storage/connector/sync/http/HttpConnectorOptions.java @@ -19,7 +19,7 @@ * Represents configuration options for the HTTP connector. */ @SuppressFBWarnings( - value = {"EI_EXPOSE_REP", "EI_EXPOSE_REP2", "CT_CONSTRUCTOR_THROW"}, + value = {"EI_EXPOSE_REP", "CT_CONSTRUCTOR_THROW"}, justification = "builder validations") @Slf4j @Getter diff --git a/tools/flagd-http-connector/src/main/java/dev/openfeature/contrib/tools/flagd/resolver/process/storage/connector/sync/http/PayloadCacheOptions.java b/tools/flagd-http-connector/src/main/java/dev/openfeature/contrib/tools/flagd/resolver/process/storage/connector/sync/http/PayloadCacheOptions.java index 14d26d1b9..4431b5ef5 100644 --- a/tools/flagd-http-connector/src/main/java/dev/openfeature/contrib/tools/flagd/resolver/process/storage/connector/sync/http/PayloadCacheOptions.java +++ b/tools/flagd-http-connector/src/main/java/dev/openfeature/contrib/tools/flagd/resolver/process/storage/connector/sync/http/PayloadCacheOptions.java @@ -1,6 +1,5 @@ package dev.openfeature.contrib.tools.flagd.resolver.process.storage.connector.sync.http; -import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.Builder; import lombok.Getter; @@ -16,9 +15,6 @@ * corner cases. *

*/ -@SuppressFBWarnings( - value = {"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}, - justification = "builder validations") @Builder @Getter public class PayloadCacheOptions {