Skip to content

feat: set evaluation-context in setProviderAndWait() #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vahidlazio merged 1 commit into from
Dec 19, 2023
Merged

feat: set evaluation-context in setProviderAndWait() #80

vahidlazio merged 1 commit into from
Dec 19, 2023

Conversation

@nicklasl
Copy link
Member

@nicklasl nicklasl commented Dec 19, 2023

This PR

  • makes it possible to use setProviderAndWait and also pass the EvaluationContext in the same call.

@nicklasl
feat: set evaluation-context in setProviderAndWait()
75955b5 
Signed-off-by: Nicklas Lundin <nicklasl@spotify.com>
@nicklasl nicklasl marked this pull request as ready for review December 19, 2023 12:51
@vahidlazio vahidlazio merged commit e19dd88 into main Dec 19, 2023
@github-actions github-actions bot mentioned this pull request Dec 19, 2023
Merged
@nicklasl nicklasl deleted the add-eval-context-param branch December 19, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vahidlazio vahidlazio vahidlazio approved these changes

@nickybondarenko nickybondarenko Awaiting requested review from nickybondarenko

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicklasl @vahidlazio