refactor: get all typings to a better spot

Author: tcarrio

src/implementation/flags/Attributes.php

@@ -36,7 +36,7 @@ public function keys(): array
     /**
      * @return bool|string|int|float|DateTime|mixed[]|null
      */
-    public function get(string $key)
+    public function get(string $key): bool | string | int | float | DateTime | array | null
     {
         if (isset($this->attributesMap[$key])) {
             return $this->attributesMap[$key];

src/implementation/flags/EvaluationDetails.php

@@ -11,6 +11,7 @@
 class EvaluationDetails implements EvaluationDetailsInterface
 {
     private string $flagKey = '';
+
     /** @var bool|string|int|float|DateTime|mixed[]|null $value */
     private bool | string | int | float | DateTime | array | null $value = null;
     private ?ResolutionError $error = null;
@@ -40,7 +41,7 @@ public function setFlagKey(string $flagKey): void
      *
      * @return bool|string|int|float|DateTime|mixed[]|null
      */
-    public function getValue()
+    public function getValue(): bool | string | int | float | DateTime | array | null
     {
         return $this->value;
     }

src/implementation/flags/EvaluationDetailsFactory.php

@@ -11,7 +11,7 @@
 class EvaluationDetailsFactory
 {
     /**
-     * Provides a simple method for building EvaluationDetails from a given value
+     * Provides a simple method for building EvaluationDetails from a given value\
      *
      * @param bool|string|int|float|DateTime|mixed[]|null $value
      */

src/implementation/flags/MutableAttributes.php

@@ -32,9 +32,6 @@ function (array $map, string $key) use ($attributes) {
         return new MutableAttributes($attributeMap);
     }
 
-    /**
-     * @param bool|string|int|float|DateTime|mixed[]|null $value
-     */
     public function add(string $key, bool | string | int | float | DateTime | array | null $value): void
     {
         $this->attributesMap[$key] = $value;

src/implementation/flags/NoOpClient.php

@@ -60,14 +60,15 @@ public function getFloatDetails(string $flagKey, float $defaultValue, ?Evaluatio
      *
      * @return mixed[]
      */
-    public function getObjectValue(string $flagKey, array $defaultValue, ?EvaluationContextInterface $context = null, ?EvaluationOptions $options = null): array
-    {
+    public function getObjectValue(
+        string $flagKey,
+        array $defaultValue,
+        ?EvaluationContextInterface $context = null,
+        ?EvaluationOptions $options = null
+    ): array {
         return $defaultValue;
     }
 
-    /**
-     * @param bool|string|int|float|DateTime|mixed[]|null $defaultValue
-     */
     public function getObjectDetails(string $flagKey, bool | string | int | float | DateTime | array | null $defaultValue, ?EvaluationContextInterface $context = null, ?EvaluationOptions $options = null): EvaluationDetails
     {
         return EvaluationDetailsFactory::from($flagKey, $defaultValue);
@@ -88,17 +89,17 @@ public function setEvaluationContext(EvaluationContextInterface $context): void
       // no-op
     }
 
-  /**
-   * @inheritdoc
-   */
+    /**
+     * @inheritdoc
+     */
     public function getHooks(): array
     {
         return [];
     }
 
-  /**
-   * @inheritdoc
-   */
+    /**
+     * @inheritdoc
+     */
     public function setHooks(array $hooks): void
     {
       // no-op

src/implementation/hooks/HookHints.php

@@ -16,9 +16,9 @@ class HookHints implements HookHintsInterface
     private array $hints = [];
 
     /**
-     * @return bool | string | float | int | DateTime | mixed[] | null
+     * @return bool|string|int|float|DateTime|mixed[]|null
      */
-    public function get(string $key)
+    public function get(string $key): bool | string | int | float | DateTime | array | null
     {
         if (key_exists($key, $this->hints)) {
             return $this->hints[$key];

src/implementation/hooks/ImmutableHookContext.php

@@ -24,7 +24,7 @@ public function getType(): string
     /**
      * @return bool|string|int|float|DateTime|mixed[]|null
      */
-    public function getDefaultValue()
+    public function getDefaultValue(): bool | string | int | float | DateTime | array | null
     {
         return $this->defaultValue;
     }

src/implementation/hooks/MutableHookContext.php

@@ -22,9 +22,6 @@ public function setType(string $type): void
         $this->type = $type;
     }
 
-    /**
-     * @param bool|string|int|float|DateTime|mixed[]|null $defaultValue
-     */
     public function setDefaultValue(bool | string | int | float | DateTime | array | null $defaultValue): void
     {
         $this->defaultValue = $defaultValue;

src/implementation/provider/AbstractProvider.php

@@ -4,6 +4,7 @@
 
 namespace OpenFeature\implementation\provider;
 
+use DateTime;
 use OpenFeature\implementation\common\Metadata;
 use OpenFeature\interfaces\common\Metadata as MetadataInterface;
 use OpenFeature\interfaces\flags\EvaluationContext;
@@ -34,7 +35,11 @@ abstract public function resolveIntegerValue(string $flagKey, int $defaultValue,
 
     abstract public function resolveFloatValue(string $flagKey, float $defaultValue, ?EvaluationContext $context = null): ResolutionDetailsInterface;
 
-    abstract public function resolveObjectValue(string $flagKey, mixed $defaultValue, ?EvaluationContext $context = null): ResolutionDetailsInterface;
+    abstract public function resolveObjectValue(
+        string $flagKey,
+        bool | string | int | float | DateTime | array | null $defaultValue,
+        ?EvaluationContext $context = null
+    ): ResolutionDetailsInterface;
 
     /**
      * @return Hook[]

src/implementation/provider/NoOpProvider.php

@@ -4,6 +4,7 @@
 
 namespace OpenFeature\implementation\provider;
 
+use DateTime;
 use OpenFeature\interfaces\flags\EvaluationContext;
 use OpenFeature\interfaces\provider\Provider;
 use OpenFeature\interfaces\provider\ResolutionDetails as ResolutionDetailsInterface;
@@ -32,8 +33,14 @@ public function resolveFloatValue(string $flagKey, float $defaultValue, ?Evaluat
         return ResolutionDetailsFactory::fromSuccess($defaultValue);
     }
 
-    public function resolveObjectValue(string $flagKey, mixed $defaultValue, ?EvaluationContext $context = null): ResolutionDetailsInterface
-    {
+    /**
+     * @param bool|string|int|float|DateTime|mixed[]|null $defaultValue
+     */
+    public function resolveObjectValue(
+        string $flagKey,
+        bool | string | int | float | DateTime | array | null $defaultValue,
+        ?EvaluationContext $context = null
+    ): ResolutionDetailsInterface {
         return ResolutionDetailsFactory::fromSuccess($defaultValue);
     }
 }