feat: Update test harness (add assertions) #1467 #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 31 31
Lines 1387 1387
=======================================
Hits 1353 1353
Misses 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
aepfli
approved these changes
Jan 21, 2025
beeme1mr
approved these changes
Jan 21, 2025
gruebel
approved these changes
Jan 21, 2025
leohoare
pushed a commit
to leohoare/python-sdk
that referenced
this pull request
Jan 22, 2025
* Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> * fixup! Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> * fixup! Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> * fixup! Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> * fixup! Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> * fixup! Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> * fixup! Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> --------- Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> Co-authored-by: Anton Grübel <anton.gruebel@gmail.com>
leohoare
pushed a commit
to leohoare/python-sdk
that referenced
this pull request
Jan 23, 2025
* Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> * fixup! Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> * fixup! Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> * fixup! Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> * fixup! Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> * fixup! Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> * fixup! Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> --------- Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> Co-authored-by: Anton Grübel <anton.gruebel@gmail.com> Signed-off-by: leohoare <leo@insight.co>
leohoare
pushed a commit
to leohoare/python-sdk
that referenced
this pull request
Jan 27, 2025
* Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> * fixup! Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> * fixup! Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> * fixup! Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> * fixup! Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> * fixup! Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> * fixup! Update test harness (add assertions) #1467 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> --------- Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> Co-authored-by: Anton Grübel <anton.gruebel@gmail.com> Signed-off-by: leohoare <leo@insight.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adds gherkin tests for flag metadata on evaluation.
This PR depends on, and is blocked by, open-feature/spec#289
Related Issues
Fixes #1467 (open-feature/flagd#1467)