fix: don't init if provider doesn't have an init method #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-beam
changed the title
nathan-beam
changed the title
Signed-off-by: Nathan Beam <nbeam@forwardfinancing.com>
nathan-beam
force-pushed
the
nb-fix-meta-init
branch
from
81080b2 to
b2cc27e
Compare
beeme1mr
approved these changes
Mar 3, 2025
beeme1mr
pushed a commit
that referenced
this pull request
Mar 3, 2025
🤖 I have created a release *beep* *boop* --- ## [0.0.5](openfeature-meta_provider/v0.0.4...openfeature-meta_provider/v0.0.5) (2025-03-03) ### 🐛 Bug Fixes * don't init if provider doesn't have an init method ([#49](#49)) ([d2479ed](d2479ed)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Zaimwa9
pushed a commit
to Zaimwa9/ruby-sdk-contrib
that referenced
this pull request
Nov 26, 2025
🤖 I have created a release *beep* *boop* --- ## [0.0.5](open-feature/ruby-sdk-contrib@openfeature-meta_provider/v0.0.4...openfeature-meta_provider/v0.0.5) (2025-03-03) ### 🐛 Bug Fixes * don't init if provider doesn't have an init method ([open-feature#49](open-feature#49)) ([d2479ed](open-feature@d2479ed)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: wadii <wadii.zaim@flagsmith.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
initif any of the sub-providers do not have an init methodRelated Issues
Notes
This was blowing up for us because one of our providers does not have an
initmethod. Sinceinitis common but not required per OpenFeature spec for providers, a simpleresponds_to?check makes this safe for all providers.Follow-up Tasks
How to test
Create a MetaProvider using a provider that does not have an
initmethod, such as this one, along with a provider that does have aninitfunction. Calliniton the MetaProvider. Assert thatinitwas not called on the provider without aninitmethod, and that it was called on the provider with aninitmethod.