feat: Improves EvaluationContext thread safety #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
vahidlazio
approved these changes
Jul 3, 2025
fabriziodemaria
changed the title
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
vahidlazio
approved these changes
Jul 4, 2025
fabriziodemaria
pushed a commit
that referenced
this pull request
Jul 4, 2025
🤖 I have created a release *beep* *boop* --- ## [0.3.1](0.3.0...0.3.1) (2025-07-04) ### ✨ New Features * Adding Cocoapods support ([#61](#61)) ([f481a51](f481a51)) * Adds watchOS / tvOS support ([#67](#67)) ([3a5af18](3a5af18)) * Improves EvaluationContext thread safety ([#69](#69)) ([65cb295](65cb295)) ### 🧹 Chore * remove podspec update script and adjust release configuration ([#65](#65)) ([2903008](2903008)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Creates a deep copy of the evaluation context before passing it into the provider. While the original evaluation context class could be mutated by the hosting application, the copy will not be affected, ensuring higher thread safety guarantees for the consuming provider.
Mutable classes are made thread safe as well.
Related Issues
Race conditions within
onContextSetimplementation have been reported for some Swift Providers.How to test
Unit tests provided for the deep copy, but difficult to test the race condition possibility.