-
Notifications
You must be signed in to change notification settings - Fork 8
feat!: Add ImmutableContext implementation #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
b39b111 to
fae07bd
Compare
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
5ad2c9e to
93be746
Compare
nicklasl
reviewed
Aug 6, 2025
Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
8eefccf to
97c748c
Compare
nicklasl
approved these changes
Aug 6, 2025
fabriziodemaria
pushed a commit
that referenced
this pull request
Aug 6, 2025
🤖 I have created a release *beep* *boop* --- ## [0.4.0](0.3.1...0.4.0) (2025-08-06) ### ⚠ BREAKING CHANGES * Add ImmutableContext implementation ([#70](#70)) ### ✨ New Features * Add ImmutableContext implementation ([#70](#70)) ([e8690d1](e8690d1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
fabriziodemaria
added a commit
that referenced
this pull request
Aug 6, 2025
Small followup from #70 Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
MutableContext, only use it in testsImmutableContext, with methods to safely edit it by returning new immutable copiesdeepCopyoperations, not needed with the new ImmutableContextRelated Issues
We've received crash reports on the Confidence Provider that we believe are caused by the passed context object being mutated at runtime.
Breaking Changes
MutableContexthas to be migrated toImmutableContext. The context semantics are unchanged: Swift immutability is the only difference that might impact the way the hosting application keeps track and forwards the context data to this SDK. Please make sure to migrate toImmutableContextthroughout your application and make that the only type passed into these APIs:setProviderandsetEvaluationContext.