feat: Allow FlagEvaluationDetails to be a public API #79
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @jescriba, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a significant enhancement by exposing the FlagEvaluationOptions struct as a public API. This change allows developers to customize flag evaluations by providing their own hooks and hints, which was previously not possible due to the internal nature of the struct's constructor and parameters. The primary impact is increased flexibility and extensibility for integrating custom logic into the flag evaluation process.
Highlights
- Public API Exposure: The
FlagEvaluationOptionsstruct, previously internal, has been made public, allowing external modules to access and utilize it for flag evaluations. - Customizable Flag Evaluation: A public initializer has been added to
FlagEvaluationOptions, enabling users to pass customhooksandhookHintswhen performing flag evaluations, enhancing flexibility.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Signed-off-by: jescriba <joshua.escribano@includedhealth.com>
jescriba
force-pushed
the
feat/update-flag-evaluation-options
branch
from
0bd1708 to
12b8c83
Compare
There was a problem hiding this comment.
Code Review
This pull request correctly exposes FlagEvaluationOptions as a public API by making its properties and initializer public. This is a good change that enables passing custom options for flag evaluations. My review includes a suggestion to mark the FlagEvaluationOptions struct as @frozen to improve performance and make the API contract more explicit, which is a best practice for public data structures in libraries.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Joshua E. <escribirajoshua@gmail.com>
jescriba
changed the title
jescriba
changed the title
beeme1mr
requested review from
fabriziodemaria,
jonathannorris and
nicklasl
There was a problem hiding this comment.
I am not sure about the frozen attribute, as the Options are something that we might want to actually evolve in the future. But no strong opinion here, since I am not familiar with this attributed anyway.
Note: there is a linter warning suggesting to move the attribute
Overall, nothing blocking on my side
Updated 👍 |
Signed-off-by: jescriba <joshua.escribano@includedhealth.com>
jescriba
force-pushed
the
feat/update-flag-evaluation-options
branch
from
ea35e93 to
784819d
Compare
🤖 I have created a release *beep* *boop* --- ## [0.5.0](0.4.0...0.5.0) (2025-11-12) ### ⚠ BREAKING CHANGES * add provider event details ([#77](#77)) ### 🐛 Bug Fixes * Prevent race condition on updateContext ([#84](#84)) ([dd23929](dd23929)) ### ✨ New Features * add multiprovider ([#78](#78)) ([869b90a](869b90a)) * add provider event details ([#77](#77)) ([56b477e](56b477e)) * add Tracking API ([#81](#81)) ([c14b0cd](c14b0cd)) * Allow FlagEvaluationDetails to be a public API ([#79](#79)) ([0b07a8f](0b07a8f)) ### 📚 Documentation * Update docs with ImmutableContext ([#72](#72)) ([28ccd3e](28ccd3e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
3 participants
This PR
Small change to enable
FlagEvaluationOptionsto be used during flag evaluations. Currently the constructor and params were internal APIs so custom options couldn't be passed in.