Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage of miflora_poller.py #46

Closed
ChristianKuehnel opened this issue Oct 18, 2017 · 0 comments
Closed

Improve test coverage of miflora_poller.py #46

ChristianKuehnel opened this issue Oct 18, 2017 · 0 comments

Comments

@ChristianKuehnel
Copy link
Collaborator

At the moment miflora_poller.py is not well tested. Please add more tests for this class. You probably need to extend the class MockBackend for that.

The goal is to have the main logic of the class properly tested

ChristianKuehnel added a commit to ChristianKuehnel/miflora that referenced this issue Oct 21, 2017
ChristianKuehnel added a commit to ChristianKuehnel/miflora that referenced this issue Oct 21, 2017
ChristianKuehnel added a commit that referenced this issue Oct 21, 2017
* Added .idea/ to gitignore, used by PyCharm

* enabled flake8 checks in travis

* miflora_poller: fixed flake8 warnings, added logging, made constants private

* fixed dependencies in tox.ini, upgraded version number on bluepy

* renamed tox environment for flake8 to "flake8"

* added more unit tests

#46

* miflora_poller: fixed flake8 warnings, added logging, made constants private

* fixed dependencies in tox.ini, upgraded version number on bluepy

* renamed tox environment for flake8 to "flake8"

* added more unit tests

#46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant