New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a possible loop in the FSM of the elections in sqliterepo #1203

Merged
merged 3 commits into from Oct 3, 2017

Conversation

Projects
None yet
3 participants
@jfsmig
Member

jfsmig commented Oct 3, 2017

No description provided.

jfsmig added some commits Oct 3, 2017

@jfsmig jfsmig self-assigned this Oct 3, 2017

@jfsmig jfsmig requested a review from fvennetier Oct 3, 2017

@jfsmig jfsmig changed the title from 4.1.x sqliterepo fix loop to Fix a possible loop in the FSM of the elections in sqliterepo Oct 3, 2017

sqliterepo/election: Comment a decision
Not so obvious at a glance
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 3, 2017

Codecov Report

Merging #1203 into 4.1.x will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.1.x    #1203      +/-   ##
==========================================
+ Coverage   75.98%   76.03%   +0.04%     
==========================================
  Files         293      293              
  Lines       53738    53806      +68     
  Branches     6618     6624       +6     
==========================================
+ Hits        40834    40909      +75     
+ Misses      12525    12484      -41     
- Partials      379      413      +34
Impacted Files Coverage Δ
sqliterepo/election.c 79.14% <100%> (+0.07%) ⬆️
tests/unit/test_sqliterepo_election.c 95.13% <100%> (+0.45%) ⬆️
meta2v2/meta2_utils_json_in.c 32.19% <0%> (-4.11%) ⬇️
meta2v2/meta2_utils.c 70.48% <0%> (-2.77%) ⬇️
oio/common/utils.py 61.88% <0%> (-0.75%) ⬇️
sqliterepo/gridd_client_pool.c 69.19% <0%> (-0.48%) ⬇️
metautils/lib/comm_converter.c 74.01% <0%> (-0.27%) ⬇️
sqliterepo/repository.c 71.9% <0%> (ø) ⬆️
sqliterepo/replication_dispatcher.c 45.54% <0%> (+0.08%) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25356fc...cf2bee3. Read the comment docs.

codecov-io commented Oct 3, 2017

Codecov Report

Merging #1203 into 4.1.x will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.1.x    #1203      +/-   ##
==========================================
+ Coverage   75.98%   76.03%   +0.04%     
==========================================
  Files         293      293              
  Lines       53738    53806      +68     
  Branches     6618     6624       +6     
==========================================
+ Hits        40834    40909      +75     
+ Misses      12525    12484      -41     
- Partials      379      413      +34
Impacted Files Coverage Δ
sqliterepo/election.c 79.14% <100%> (+0.07%) ⬆️
tests/unit/test_sqliterepo_election.c 95.13% <100%> (+0.45%) ⬆️
meta2v2/meta2_utils_json_in.c 32.19% <0%> (-4.11%) ⬇️
meta2v2/meta2_utils.c 70.48% <0%> (-2.77%) ⬇️
oio/common/utils.py 61.88% <0%> (-0.75%) ⬇️
sqliterepo/gridd_client_pool.c 69.19% <0%> (-0.48%) ⬇️
metautils/lib/comm_converter.c 74.01% <0%> (-0.27%) ⬇️
sqliterepo/repository.c 71.9% <0%> (ø) ⬆️
sqliterepo/replication_dispatcher.c 45.54% <0%> (+0.08%) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25356fc...cf2bee3. Read the comment docs.

@jfsmig jfsmig merged commit 3fa0fe9 into open-io:4.1.x Oct 3, 2017

3 checks passed

codecov/patch 100% of diff hit (target 75.98%)
Details
codecov/project 76.03% (+0.04%) compared to 25356fc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jfsmig jfsmig deleted the jfsmig:4.1.x-sqliterepo-fix-loop branch Oct 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment