Permalink
Commits on Feb 21, 2017
  1. Merge pull request #41 from cleech/master

    qedi driver support
    cleech committed on GitHub Feb 21, 2017
  2. fix timeout setting on discoverydb commands

    After the changeset "Use timeout when waiting for responses from iscsid"
    discoverydb commands from iscsiadm are apparently running with a 0
    timeout and failing when the response from iscsid isn't already in the
    socket buffer when poll is called.
    
    This change seems to fix it.  All this can probably be cleaned up more,
    I was just trying to trace down where the missing assignment was and ran
    across multiple sites where it was later be zeroed again.
    
    Signed-off-by: Chris Leech <cleech@redhat.com>
    cleech committed Feb 16, 2017
Commits on Feb 15, 2017
  1. iscsiuio: v0.7.8.3

    Signed-off-by: Manish Rangankar <manish.rangankar@cavium.com>
    Signed-off-by: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com>
    Signed-off-by: Nilesh Javali <nilesh.javali@cavium.com>
    Nilesh Javali committed with cleech Nov 11, 2016
  2. iscsiuio: Add support for the new qedi transport

    Signed-off-by: Manish Rangankar <manish.rangankar@cavium.com>
    Signed-off-by: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com>
    Signed-off-by: Nilesh Javali <nilesh.javali@cavium.com>
    Nilesh Javali committed with cleech Nov 11, 2016
  3. iscsid: Changes to support the new qedi transport

    Signed-off-by: Manish Rangankar <manish.rangankar@cavium.com>
    Signed-off-by: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com>
    Signed-off-by: Nilesh Javali <nilesh.javali@cavium.com>
    Nilesh Javali committed with cleech Nov 11, 2016
Commits on Dec 5, 2016
  1. Merge pull request #34 from gonzoleeman/master

    These are the "cleanup shutdown" changes discussed and approved on the mailing list
    gonzoleeman committed on GitHub Dec 5, 2016
Commits on Dec 2, 2016
  1. Make event_loop_stop volatile for safer access

    As suggested by Christian Seiler:
    "Only minor thing is that you might want to mark
    static int event_loop_stop; (usr/event_poll.c)
    to be volatile, to be on the safe side when modifying it
    from within a signal handler. Probably not really required
    here (the compiler is not allowed to optimize out the
    access anyway, since you call non-static functions within
    the loop), but it doesn't hurt either, just in case... "
    Lee Duncan committed Dec 2, 2016
Commits on Nov 23, 2016
  1. iscsid: treat SIGTERM like "iscsiadm -k 0"

    The same code that is executed by iscsid
    when iscsiadm sends the "immediate stop"
    command should be executed when iscsid
    receives a SIGTERM.
    
    Changes since v1:
     * now just set the "event loop stop" flag
    
    Signed-off-by: Lee Duncan <lduncan@suse.com>
    Lee Duncan committed Nov 23, 2016
  2. Use timeout when waiting for responses from iscsid

    The server might already been terminated when iscsiadm tries to
    send a request to it, hence we might be waiting forever for a reply.
    With this patchset we're waiting at most one minute before giving up,
    avoiding a hang in iscsiadm.
    
    Changes since v2:
     * rework readability in new poll() code
    
    Changes since v1:
     * Break out of poll() loop on error
     * Initialize discovery timeout
    
    Signed-off-by: Hannes Reinecke <hare@suse.com>
    Signed-off-by: Lee Duncan <lduncan@suse.com>
    hreinecke committed with Lee Duncan Nov 22, 2016
Commits on Nov 18, 2016
  1. Merge pull request #32 from gonzoleeman/master

    iBFT 'origin' is an enum, not a string
    gonzoleeman committed on GitHub Nov 18, 2016
  2. iBFT 'origin' is an enum, not a string

    A recent change, commit 4959a89, modified open-iscsi
    to treat the "origin" field as an enum, not a character
    string. But one spot was missed.
    gonzoleeman committed with Lee Duncan Jul 10, 2015
Commits on Sep 29, 2016
  1. Merge pull request #30 from cleech/master

    Update URL in docs and tag release 2.0.874
    cleech committed on GitHub Sep 29, 2016
  2. Prepare to tag release 2.0.874

    cleech committed Sep 29, 2016
  3. Replace open-iscsi.org with open-iscsi.com in docs

    Replaced in README and man pages
    cleech committed Sep 29, 2016
  4. Merge pull request #29 from chris-se/debian-patches

    Patches carried in Debian
    cleech committed on GitHub Sep 29, 2016
Commits on Sep 18, 2016
  1. iscsiuio/Makefile.am: fix typo introduced by reproducibility patch

    Signed-off-by: Christian Seiler <christian@iwakd.de>
    chris-se committed Sep 18, 2016
  2. Additional spelling fixes

    These spelling mistakes were found by Debian's QA tool lintian.
    
    Signed-off-by: Christian Seiler <christian@iwakd.de>
    chris-se committed Sep 18, 2016
  3. Spelling fixes

    scop committed with chris-se Sep 18, 2016
  4. man page syntax fixes

    scop committed with chris-se Sep 18, 2016
  5. typo in man iscsiadm(8)

    eworm-de committed with chris-se Sep 18, 2016
  6. fixed typo in iscsi_discovery usage()

    quick fix changing trasnpot into transport
    MagicalTux committed with chris-se Sep 18, 2016
  7. iscsiuio: Make builds reproducible if SOURCE_DATE_EPOCH is set

    Build systems that capture the build date do not create reproducible
    binaries. If the builds are reproducible on a bit level, the build time
    stamp is actually irrelevant. A much better time stamp would be the
    last change of the source package. For this reason, a standard was
    devised that this date could be passed in externally to build systems:
    the environment variable SOURCE_DATE_EPOCH could contain the UNIX
    timestamp of the source package's last modification, and the build
    system could use that instead of the current date and time.
    
    On Debian systems (but there are also efforts to make e.g. Fedora
    reproducible) the Debian tooling would pass SOURCE_DATE_EPOCH into the
    build system.
    
    Alter iscsiuio/Makefile.am and iscsiuio/configure.ac to use that
    environment variable if set instead of the current date to create
    src/unix/build_date.c.
    
    Additionally, enforce UTC as time zone when SOURCE_DATE_EOPCH is set,
    to ensure that the user's time zone has no bearing when trying to build
    a binary that's supposed to be reproducible.
    
    See also:
    
    https://reproducible-builds.org/docs/timestamps/
    https://reproducible-builds.org/docs/timezones/
    https://reproducible-builds.org/specs/source-date-epoch/
    
    Signed-off-by: Christian Seiler <christian@iwakd.de>
    chris-se committed Sep 18, 2016
Commits on Sep 9, 2016
  1. Merge pull request #26 from cvubrugier/master

    Fix typos in iscsiadm man page
    gonzoleeman committed on GitHub Sep 9, 2016
Commits on Aug 21, 2016
  1. Fix typos in iscsiadm man page

    Also remove trailing whitespaces.
    
    Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
    cvubrugier committed Aug 21, 2016
Commits on Aug 11, 2016
  1. Merge pull request #25 from cleech/master

    old fixes that need merging
    cleech committed on GitHub Aug 11, 2016
  2. Merge pull request #22 from frank-fegert/master

    Segfaults from iscsiuio (iscsiuio/src/unix/nic_nl.c)
    gonzoleeman committed on GitHub Aug 11, 2016
Commits on Jul 31, 2016
  1. iscsiuio: ensure unlock of mutex in case of an error.

    Previously locked mutex "nl_process_mutex" should be unlocked in
    case the threads main loop exits due to an error.
    frank-fegert committed Jul 31, 2016
Commits on Jul 28, 2016
Commits on Apr 12, 2016
  1. remove sysfs attr_list

    The global cache is not well designed, it quickly can grow to the point
    where lookups take much longer than just doing the sysfs read in the
    first place.
    
    v2: initialized 'value' array in sysfs_attr_get_value to fix issue when
        checking for an attr that doesn't exist
    
    v3: fix another behavior change when checking ofr non-existent attrs,
        make sure we return NULL and not an empty string
    cleech committed Feb 17, 2016
  2. iscsid: make safe_logut session checks apply for flashnode session

    Make the safe_logout option work with flashnode sessions as well.
    Moves the code into a new file shared between iscsid and iscsiadm.
    cleech committed Jul 24, 2015
  3. iscsid: safe_logout fix device path canonicalization by using libmoun…

    …t cache
    
    Fix for the safe_logout options use of libmount.  If the cache API isn't
    used then device name canonicalization doesn't happen, and proper
    detection of devices mounted by a label doesn't work.
    cleech committed Jul 21, 2015
  4. iscsistart: support booting over a VLAN

    Adds code to check for VLAN devices if the boot configuration specifies
    a VLAN ID.
    
    Does not create VLANs, they need to already be in place.
    cleech committed Jun 17, 2015
  5. iscsiadm: fix parallel rescan handling of exit codes

    The parallel rescan patches work, in so much as the rescans happen, but
    if a target is specified the non-matching cases cause warning to be
    printed and a non-zero exit code.
    
    To reproduce: have more than one session to different targets, issue a
    node mode rescan command to one of them (-m node -T <iqn.target> -R).
    
    The problem is that while exit() takes an int, only the low byte is part
    of the exit code and it's combined with other exit status information.
    iscsiadm tries to use exit(-1) to indicate a non-match (not a fatal
    error). The value retrieved with wait() after an exit(-1) is actually
    65280.
    
    Fix this by making use of the wait.h macros for checking the exit code.
    cleech committed Apr 8, 2016
  6. iscsi_tcp set SO_LINGER to abort connection for error handling

    When requests are being failed it's important to abort the TCP
    connection rather than let TCP wait and attempt a graceful shutdown.
    
    That can be accomplished by setting the SO_LINGER socket option with a
    linger time of 0 to drop queued data and close the connection with a RST
    instead of a FIN.
    
    Signed-off-by: Chris Leech <cleech@redhat.com>
    cleech committed Feb 29, 2016
  7. Build system: sort object file lists

    Hi,
    
    Debian is currently working on making the entire archive build
    reproducibly. <https://reproducible-builds.org/> is a good
    resource describing the motivation behind this effort.
    
    There was one problem that was found in the open-iscsi package
    build system that prevented builds from being reproducible:
    the list of object files generated by the wildcard Makefile
    function are not in a deterministic order, causing changes in
    the output depending on the order in the underlying filesystem.
    
    I've attached a patch against the current git master that
    sorts the list of object files within the Makefile, making the
    order deterministic and allowing reproducible builds to be
    made. See also:
    <https://reproducible-builds.org/docs/stable-inputs/>
    
    It would be great if you could apply this patch upstream, so we
    don't have to carry it in Debian.
    
    Thanks!
    
    Regards,
    Christian
    
    --
    You received this message because you are subscribed to the Google Groups "open-iscsi" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@googlegroups.com.
    To post to this group, send email to open-iscsi@googlegroups.com.
    Visit this group at https://groups.google.com/group/open-iscsi.
    For more options, visit https://groups.google.com/d/optout.
    
    From a919d214d10870a54c6a5e383a19a6e82e5f8a54 Mon Sep 17 00:00:00 2001
    From: Christian Seiler <christian@iwakd.de>
    Date: Sat, 13 Feb 2016 00:56:19 +0100
    Subject: [PATCH] Build system: sort object file lists
    
    The object file list generated by the wildcard Makefile function is not
    deterministic, because it may change depending on the underlying file
    system.
    
    Use the sort function to make the list deterministic in these cases, to
    be able to build open-iscsi deterministically. See
    <https://reproducible-builds.org/>
    for further details.
    
    Signed-off-by: Christian Seiler <christian@iwakd.de>
    Christian Seiler committed with cleech Feb 13, 2016