rbd: new option for specifying the id #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows differnt ids to connect to the RADOS cluster
|
Looks good to me |
| @@ -423,7 +424,7 @@ static int tcmu_rbd_image_open(struct tcmu_device *dev) | |||
| struct tcmu_rbd_state *state = tcmu_get_dev_private(dev); | |||
| int ret; | |||
|
|
|||
| ret = rados_create(&state->cluster, NULL); | |||
| ret = rados_create(&state->cluster, state->id); | |||
There was a problem hiding this comment.
Thanks for the patch.
Did you want to use the rados_create2 full name support instead of the rados_create id where "client" is assumed to be the prefix?
There was a problem hiding this comment.
For our current use case, assuming "client" is okay with us, and we don't currently have any plans for setting the cluster name.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows differnt ids to connect to the RADOS cluster