runner/rbd: misc implicit failover fixes #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikechristie
changed the title
dillaman
reviewed
Aug 30, 2018
alua.c
Outdated
| @@ -387,8 +387,8 @@ static int alua_set_state(struct tcmu_device *dev, struct alua_grp *group, | |||
| * @group_list: list of alua groups | |||
| * @enabled_group_id: group id of the local enabled alua group | |||
| * | |||
| * If the handler is not able to update the remote nodes's state during STPG | |||
| * handling we update it now. | |||
| * If the handler is not able to update the remote nodes's state during alua | |||
There was a problem hiding this comment.
Thanks. Fixed.
Patches merged.
added 2 commits
August 30, 2018 12:38
Update lock state when getting a RTPG or INQUIRY to make sure when a path is added back after a failover, we re-grab the lock. Signed-off-by: Mike Christie <mchristi@redhat.com>
Linux does not handle alua state transition well starting with this
patch:
commit 2b35865e7a290d313c3d156c0c2074b4c4ffaf52
Author: Hannes Reinecke <hare@suse.de>
Date: Fri Feb 19 09:17:13 2016 +0100
scsi_dh_alua: Recheck state on unit attention
Before this patch linux would retry for up to (cmd retries *
cmd timeout) seconds. With that patch it only retries 5 times. Because
we are not doing disk/ssd IO the retries could be used up before we even
start to take the lock. This results in the cmd being failed to the
multipath layer, the path being failed and the IO retried on another
path. This could then repeat over and over on each path.
We work around this by just returning BUSY.
Signed-off-by: Mike Christie <mchristi@redhat.com>
mikechristie
force-pushed
the
fix-implicit-lock-state
branch
from
ae613ee
to
ba66096
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update lock state when getting a RTPG or INQUIRY to make sure when a
path is added back after a failover, we re-grab the lock later.
Use BUSY instead of ALUA STATE TRANSITION to work around a bug in the linux alua layer.