Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix for not being able to run vagrant up under OSX #766

Merged
merged 2 commits into from May 10, 2017

Conversation

snazzybunny
Copy link
Member

@snazzybunny snazzybunny commented May 8, 2017

Added a suggestion for users experiencing the error "vi: Box 'ole/jessie64' could not be found. Attempting to find and install...". If the answer is on the page somewhere, users may less likely be deterred from installing Vagrant, saving the user time. I put all of this under a troubleshooting section near the end of document.

Update by @mappuji :
Rawgit here

@snazzybunny
Copy link
Member Author

#765 for discussion.

Copy link
Contributor

@empeje empeje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things I've reviewed:

  • Check for issue number in pull request title
  • Are there any unneeded files in the pull request?
  • Did they make a branch for their patch?
  • Does the pull request actually fix the issue?
  • Check the pull request on rawgit, does it display without any errors?
  • Is there any merge conflicts?
  • Check the committer name?

Notes:

  • Basically I agree with the changes, but I don't know much about installing on Mac, others please review about this.
  • I also wonder, which one better to put this kind of troubleshooting solution, in FAQ or directly on the instruction page. Any suggestion?

Copy link
Contributor

@empeje empeje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my additional reviews.

Also in line 90 (old version) please fix the Header 4 formatting with adding a space after the last hashtag #.

pages/vagrant.md Outdated
## Troubleshooting
When typing the command "vagrant up" in OSX, you may experience an error such as the following: "vi: Box 'ole/jessie64' could not be found. Attempting to find and install...". A simple solution is to perform the command below. ```sudo rm /opt/vagrant/embedded/bin/curl``` This will remove the old version of curl and vagrant should now work as usual.

For more information go here: (http://stackoverflow.com/questions/23874260/error-when-trying-vagrant-up)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to create a markdown link for the StackOverflow discussion.
Example: [Caption](URL)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions. I have added the proper markdown URL and also fixed the header formatting.

Copy link
Contributor

@empeje empeje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things I've reviewed:

  • Check for issue number in pull request title
  • Are there any unneeded files in the pull request?
  • Did they make a branch for their patch?
  • Does the pull request actually fix the issue?
  • Check the pull request on rawgit, does it display without any errors?
  • Is there any merge conflicts?
  • Check the committer name?

@empeje empeje merged commit 781ce36 into open-learning-exchange:master May 10, 2017
@snazzybunny snazzybunny deleted the snazzybunny-patch-1 branch May 10, 2017 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants