Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Add setup multi-processing both in train and test. #671

Merged
merged 1 commit into from Jan 27, 2022

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Jan 25, 2022

Motivation

Refers to open-mmlab/mmdetection#7036

According to some tests, these setup items can avoid some problems which slow down the training speed. Test on mmcls will be added after.

Modification

Add setup multi-processing both in train and test.
Add unit tests.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@mzr1996 mzr1996 requested a review from Ezra-Yu January 25, 2022 07:14
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #671 (369d386) into dev (bd397f7) will increase coverage by 0.04%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #671      +/-   ##
==========================================
+ Coverage   82.27%   82.31%   +0.04%     
==========================================
  Files         120      121       +1     
  Lines        7045     7068      +23     
  Branches     1228     1232       +4     
==========================================
+ Hits         5796     5818      +22     
  Misses       1075     1075              
- Partials      174      175       +1     
Flag Coverage Δ
unittests 82.31% <95.83%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/utils/setup_env.py 95.45% <95.45%> (ø)
mmcls/utils/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd397f7...369d386. Read the comment docs.

Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzr1996 mzr1996 merged commit f552419 into open-mmlab:dev Jan 27, 2022
Ezra-Yu pushed a commit to Ezra-Yu/mmclassification that referenced this pull request Feb 14, 2022
@mzr1996 mzr1996 deleted the setup-env branch July 20, 2022 06:55
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants