fix roi align symbolic for torch>1.13

[grimoire]

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Torch>=1.13 would not wrap Graph into GraphContext, so we can not reuse some tools in torch.onnx.

Modification

Update roi_align symbolic.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

• I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
• Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
• Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
• New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
• The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

• If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
• CLA has been signed and all committers have signed the CLA in this PR.

[codecov]

Codecov Report

Base: 66.60% // Head: 66.60% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f090bc8) compared to base (4e0341f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##              2.x    #2443   +/-   ##
=======================================
  Coverage   66.60%   66.60%           
=======================================
  Files         120      120           
  Lines        7800     7801    +1     
  Branches     1067     1067           
=======================================
+ Hits         5195     5196    +1     
  Misses       2438     2438           
  Partials      167      167           

Flag	Coverage Δ
unittests	66.60% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
mmcv/ops/roi_align.py	76.25% <100.00%> (+0.30%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[smatrix017]

I see this has been merged to open-mmlab:2.x branch, is there any timeline to fix for mmcv 1.x versions?

[zhouzaida]

I see this has been merged to open-mmlab:2.x branch, is there any timeline to fix for mmcv 1.x versions?

Hi @smatrix017 , we will pick this commit to mmcv1.x this month.

[smatrix017]

Hi @zhouzaida, Thanks for the response. I am trying the rc 2.x mmcv version and getting following error while onnx conversion:

torch.onnx.errors.CheckerError: Unrecognized attribute: axes for operator Squeeze

==> Context: Bad node spec for node. Name: /roi_extractor/extractor/roi_layers.0/Squeeze OpType: Squeeze

Any idea what is going wrong here?

I was getting the same error when I applied the changes in this PR to mmcv version 1.7 as well.

PS: Apologies if this is not the correct place. I can open a separate issue if you want

[buzuyun]

@smatrix017 Hi, I've encountered a same issue in the environment with mmcv-full=1.7.2 and torch=1.13.1. Have you managed to resolve it? If so, any guidance you could provide would be greatly appreciated. Thank you in advance for your help!