Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add npu adapter for deformableroipool #2481

Merged
merged 10 commits into from
Dec 14, 2022
Merged

Conversation

jayggh
Copy link

@jayggh jayggh commented Dec 10, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

This PR contains a npu-adapter of mmcv ops-deformableroipool. we can run these ops(above) on ascend-npu device by these adapters.

Modification

deform_roi_pool.cpp is added to the PR which is used for deformroipool npu-adaptation, while test_deform_roi_pool.py is modified by the PR.

Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida zhouzaida added the NPU Ascend label Dec 13, 2022
@jayggh jayggh changed the title add npu adapter for deformroipool add npu adapter for deformableroipool Dec 13, 2022
@zhouzaida zhouzaida merged commit 46eb9ec into open-mmlab:master Dec 14, 2022
@jayggh jayggh deleted the deformroipool branch December 14, 2022 08:06
ckirchhoff2021 pushed a commit to ckirchhoff2021/mmcv that referenced this pull request Dec 21, 2022
* add npu adapter for deformroipool

* cleancode

* Update deform_roi_pool.cpp

* Update deform_roi_pool.cpp

* Update deform_roi_pool.cpp

* Update deform_roi_pool.cpp

* Update deform_roi_pool.cpp

* Update deform_roi_pool.cpp

* Update deform_roi_pool.cpp
defei-coder pushed a commit to defei-coder/mmcv that referenced this pull request Jan 30, 2023
* add npu adapter for deformroipool

* cleancode

* Update deform_roi_pool.cpp

* Update deform_roi_pool.cpp

* Update deform_roi_pool.cpp

* Update deform_roi_pool.cpp

* Update deform_roi_pool.cpp

* Update deform_roi_pool.cpp

* Update deform_roi_pool.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPU Ascend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants