Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support streaming reading of frames in video interpolation demo #790

Merged
merged 3 commits into from Mar 19, 2022

Conversation

Yshuo-Li
Copy link
Collaborator

@Yshuo-Li Yshuo-Li commented Mar 16, 2022

motivation
Video interpolation demo read the whole video into RAM, which can easily lead to overflow.

@mm-assistant mm-assistant bot added the size/XS label Mar 16, 2022
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #790 (16f05e2) into master (696e3a8) will decrease coverage by 0.00%.
The diff coverage is 88.15%.

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
- Coverage   83.05%   83.04%   -0.01%     
==========================================
  Files         216      216              
  Lines       12192    12240      +48     
  Branches     1964     1975      +11     
==========================================
+ Hits        10126    10165      +39     
- Misses       1763     1767       +4     
- Partials      303      308       +5     
Flag Coverage Δ
unittests 83.00% <88.15%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/apis/video_interpolation_inference.py 86.40% <87.83%> (-4.83%) ⬇️
...t/models/video_interpolators/basic_interpolator.py 97.36% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 696e3a8...16f05e2. Read the comment docs.

@wangruohui wangruohui merged commit 7cb8153 into open-mmlab:master Mar 19, 2022
@Yshuo-Li Yshuo-Li deleted the demo+ branch April 7, 2022 07:41
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
…demo (open-mmlab#790)

* [Feature] Support streaming reading of frames

* [Feature] Support streaming reading of frames

* Support gray input in EDSR
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
…demo (open-mmlab#790)

* [Feature] Support streaming reading of frames

* [Feature] Support streaming reading of frames

* Support gray input in EDSR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants