Add list_from_file and list_to_file #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lizz <lizz@sensetime.com>
Codecov Report
@@ Coverage Diff @@
## main #226 +/- ##
==========================================
+ Coverage 85.94% 85.96% +0.02%
==========================================
Files 131 132 +1
Lines 8807 8807
Branches 1239 1239
==========================================
+ Hits 7569 7571 +2
+ Misses 936 934 -2
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| line = line.strip() | ||
| if line != '': | ||
| self.idx2char.append(line) | ||
| for line in list_from_file(dict_file): |
There was a problem hiding this comment.
BE CAREFUL. MAKE SURE THERE IS NO PROBLEM ABOUT SOME CHARACTERS SUCH AS CHINESE
There was a problem hiding this comment.
Will add tests on that
There was a problem hiding this comment.
Tests added. Any more to add?
cuhk-hbsun
approved these changes
May 24, 2021
gaotongxiao
pushed a commit
to gaotongxiao/mmocr
that referenced
this pull request
Jul 15, 2022
* Add list_from_file and list_to_file Signed-off-by: lizz <lizz@sensetime.com> * Add test list_to_file and list_from_file * more * Fix tests
gaotongxiao
pushed a commit
to gaotongxiao/mmocr
that referenced
this pull request
Jul 15, 2022
* Add list_from_file and list_to_file Signed-off-by: lizz <lizz@sensetime.com> * Add test list_to_file and list_from_file * more * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies code, and avoids direct manipulations of text io.