Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix the bug of 'sigma' and 'output file name' in bottom_up_img_demo.py #1107

Merged
merged 5 commits into from Dec 28, 2021

Conversation

chenxinfeng4
Copy link
Contributor

Motivation

Fix the bugs while using the bottom_up_img_demo.py

Modification

  • Use the custom sigma if user have defined it in config file. It's vital especially when the keypoint number in custom dataset is the same as the default human pose.
  • fix the bug of output file name

@CLAassistant
Copy link

CLAassistant commented Dec 27, 2021

CLA assistant check
All committers have signed the CLA.

@jin-s13 jin-s13 requested a review from ly015 December 27, 2021 06:43
@jin-s13
Copy link
Collaborator

jin-s13 commented Dec 27, 2021

Thanks for your contribution! @chenxinfeng4
Please sign CLA so that we can merge this change.

@ly015
Copy link
Member

ly015 commented Dec 27, 2021

Thank you very much for your contribution. This PR is possibly partially duplicated with #1101 . Could you please rebase your branch onto master and solve the conflict?

@ly015 ly015 requested a review from liqikai9 December 27, 2021 06:57
@liqikai9
Copy link
Collaborator

liqikai9 commented Dec 27, 2021

Thanks for your contribution! @chenxinfeng4
Your code is clearer than PR #1101 . Could you please rebase your branch onto the latest master branch and solve the conflict?

@chenxinfeng4
Copy link
Contributor Author

I've solve the conflict in last MERGE (commit = a5d5eca). Please check it.

@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #1107 (0d177bf) into master (66651f5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1107      +/-   ##
==========================================
- Coverage   83.39%   83.38%   -0.01%     
==========================================
  Files         196      196              
  Lines       15146    15144       -2     
  Branches     2736     2736              
==========================================
- Hits        12631    12628       -3     
  Misses       1823     1823              
- Partials      692      693       +1     
Flag Coverage Δ
unittests 83.32% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/apis/inference.py 48.98% <100.00%> (-0.35%) ⬇️
mmpose/datasets/pipelines/shared_transform.py 85.36% <0.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76060f4...0d177bf. Read the comment docs.

@liqikai9
Copy link
Collaborator

I've solve the conflict in last MERGE (commit = a5d5eca). Please check it.

There seems to have some lint problem. You can follow this guide to install pre-commit hook , which can check and format the code automatically on every commit.

@ly015 ly015 changed the title fix the bug of 'sigma' and 'output file name' in bottom_up_img_demo.py [Fix] fix the bug of 'sigma' and 'output file name' in bottom_up_img_demo.py Dec 28, 2021
@ly015 ly015 merged commit 74cfbe9 into open-mmlab:master Dec 28, 2021
@OpenMMLab-Assistant-004
Copy link

Hi @chenxinfeng4 !First of all, we want to express our gratitude for your significant PR in the mmpose project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
…demo.py (open-mmlab#1107)

* fix the bug of 'sigma' and 'output file name' in bottom_up_img_demo.py

* Fix the code style

* Fix the code style
HAOCHENYE added a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
* [Fix] Fix build unnecessary loop during train/test/val

* move unit test to runner

* Update unit test

* Fix unit test

* check train_loop is None

* update comment

* replace(type(None)) with is not None
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
…demo.py (open-mmlab#1107)

* fix the bug of 'sigma' and 'output file name' in bottom_up_img_demo.py

* Fix the code style

* Fix the code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants