Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] support DEKR #1693

Merged
merged 9 commits into from Oct 14, 2022
Merged

[Feature] support DEKR #1693

merged 9 commits into from Oct 14, 2022

Conversation

JinluZhang1126
Copy link

Motivation

To support the single-stage model, DEKR, which is missed in previous versions of MMPose.

Modification

add single-stage config files in the './configs' directory;
add OneStage detector class and corresponding regression head in the './mmpose/model' directory;
update the bottom-up data transformation like generating offsets, multi-scale, and match_to_heatmap in the './mmpose/datasets' directory...

BC-breaking (Optional)

No.

Use cases (Optional)

python tools/train.py configs/body/2d_kpt_sview_rgb_img/onestage/coco/hrnet_w48_coco_640x640.py

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2022

CLA assistant check
All committers have signed the CLA.

@Ben-Louis Ben-Louis self-assigned this Sep 28, 2022
@Ben-Louis Ben-Louis changed the base branch from master to dev-0.29 September 29, 2022 02:06
@Ben-Louis Ben-Louis changed the base branch from dev-0.29 to master October 11, 2022 07:58
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 83.87% // Head: 84.19% // Increases project coverage by +0.31% 🎉

Coverage data is based on head (25ee1dd) compared to base (fd7ff85).
Patch coverage: 87.28% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1693      +/-   ##
==========================================
+ Coverage   83.87%   84.19%   +0.31%     
==========================================
  Files         238      241       +3     
  Lines       20549    21039     +490     
  Branches     3535     3741     +206     
==========================================
+ Hits        17236    17714     +478     
  Misses       2403     2403              
- Partials      910      922      +12     
Flag Coverage Δ
unittests 84.10% <87.28%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/models/losses/__init__.py 100.00% <ø> (ø)
mmpose/models/detectors/one_stage.py 74.23% <74.23%> (ø)
mmpose/datasets/pipelines/bottom_up_transform.py 63.81% <87.40%> (+5.90%) ⬆️
mmpose/core/post_processing/nms.py 90.07% <91.42%> (+0.49%) ⬆️
mmpose/models/utils/rescore.py 94.28% <94.28%> (ø)
mmpose/models/heads/dekr_head.py 94.80% <94.80%> (ø)
mmpose/core/evaluation/bottom_up_eval.py 82.85% <100.00%> (+9.32%) ⬆️
mmpose/core/post_processing/__init__.py 100.00% <100.00%> (ø)
mmpose/core/post_processing/group.py 90.32% <100.00%> (+2.46%) ⬆️
mmpose/core/post_processing/post_transforms.py 95.23% <100.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ly015 ly015 merged commit 3fbd7b6 into open-mmlab:master Oct 14, 2022
evendrow pushed a commit to evendrow/mmpose that referenced this pull request Dec 22, 2022
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 5, 2023
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants