Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
ci.inria.fr/sonarscanner: move rules ignoring to the web UI
common-c:* rules didn't get ignored anyway,
move all of them to the web UI where ignoring works better.

https://docs.sonarqube.org/latest/project-administration/narrowing-the-focus/

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
(cherry picked from commit c978f9a)
  • Loading branch information
bgoglin committed Sep 21, 2020
1 parent c61f630 commit e11730a
Showing 1 changed file with 0 additions and 84 deletions.
84 changes: 0 additions & 84 deletions contrib/ci.inria.fr/job-3-sonarscanner.sh
Expand Up @@ -160,90 +160,6 @@ sonar.c.cppcheck.reportPath=${CPPCHECK_XMLS}
sonar.c.includeDirectories=$(echo | gcc -E -Wp,-v - 2>&1 | grep "^ " | tr '\n' ',')include,hwloc,utils/lstopo,utils/hwloc
sonar.c.rats.reportPath=${RATS_XMLS}
sonar.c.valgrind.reportPath=${VALGRIND_XMLS}
sonar.issue.ignore.multicriteria=c1,c2,c3,c4,c5,c6,c7,c8,c9,c10,c11,c12,c13,c14,c15,c16,c17,c18,c19,c20,r1,r2,r3,r4,r5,r6,r7
# Sharing some naming conventions is a key point to make it possible for a team to efficiently collaborate. This rule allows to check that all class names match a provided regular expression.
sonar.issue.ignore.multicriteria.c1.ruleKey=c:ClassName
sonar.issue.ignore.multicriteria.c1.resourceKey=**/*
# The file is too complex (392 while maximum allowed is set to 200).
sonar.issue.ignore.multicriteria.c2.ruleKey=c:FileComplexity
sonar.issue.ignore.multicriteria.c2.resourceKey=**/*
# Add or update the header of this file.
sonar.issue.ignore.multicriteria.c3.ruleKey=c:FileHeader
sonar.issue.ignore.multicriteria.c3.resourceKey=**/*
# Rename this file to match this regular expression: "(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$".
sonar.issue.ignore.multicriteria.c4.ruleKey=c:FileName
sonar.issue.ignore.multicriteria.c4.resourceKey=**/*
# The Cognitive Complexity of this function is 17 which is greater than 15 authorized.
sonar.issue.ignore.multicriteria.c5.ruleKey=c:FunctionCognitiveComplexity
sonar.issue.ignore.multicriteria.c5.resourceKey=**/*
# The Cyclomatic Complexity of this function is 30 which is greater than 10 authorized.
sonar.issue.ignore.multicriteria.c6.ruleKey=c:FunctionComplexity
sonar.issue.ignore.multicriteria.c6.resourceKey=**/*
# Rename function "hwloc_get_proc_last_cpu_location" to match the regular expression ^[a-z_][a-z0-9_]{2,30}$.
sonar.issue.ignore.multicriteria.c7.ruleKey=c:FunctionName
sonar.issue.ignore.multicriteria.c7.resourceKey=**/*
# 197 more comment lines need to be written to reach the minimum threshold of 25.0% comment density.
# BUG: this rule doesn't work, either with no prefix or "c" or "common-c"
sonar.issue.ignore.multicriteria.c8.ruleKey=common-c:InsufficientCommentDensity
sonar.issue.ignore.multicriteria.c8.resourceKey=**/*
# 3 more lines of code need to be covered by tests to reach the minimum threshold of 65.0% lines coverage.
# BUG: this rule doesn't work, either with no prefix or "c" or "common-c"
sonar.issue.ignore.multicriteria.c9.ruleKey=common-c:InsufficientLineCoverage
sonar.issue.ignore.multicriteria.c9.resourceKey=**/*
# Extract this magic number '3' into a constant, variable declaration or an enum.
sonar.issue.ignore.multicriteria.c10.ruleKey=c:MagicNumber
sonar.issue.ignore.multicriteria.c10.resourceKey=**/*
# Missing curly brace.
sonar.issue.ignore.multicriteria.c11.ruleKey=c:MissingCurlyBraces
sonar.issue.ignore.multicriteria.c11.resourceKey=**/*
# Refactor this code to not nest more than 3 if/switch/try/for/while/do statements.
sonar.issue.ignore.multicriteria.c12.ruleKey=c:NestedStatements
sonar.issue.ignore.multicriteria.c12.resourceKey=**/*
# Define a constant instead of duplicating this literal "linuxpci" 2 times.
sonar.issue.ignore.multicriteria.c13.ruleKey=c:StringLiteralDuplicated
sonar.issue.ignore.multicriteria.c13.resourceKey=**/*
# Replace all tab characters in this file by sequences of white-spaces.
sonar.issue.ignore.multicriteria.c14.ruleKey=c:TabCharacter
sonar.issue.ignore.multicriteria.c14.resourceKey=**/*
# Complete the task associated to this TODO comment.
sonar.issue.ignore.multicriteria.c15.ruleKey=c:TodoTagPresence
sonar.issue.ignore.multicriteria.c15.resourceKey=**/*
# Split this 166 characters long line (which is greater than 160 authorized).
sonar.issue.ignore.multicriteria.c16.ruleKey=c:TooLongLine
sonar.issue.ignore.multicriteria.c16.resourceKey=**/*
# The number of code lines in this function is 212 which is greater than 200 authorized.
sonar.issue.ignore.multicriteria.c17.ruleKey=c:TooManyLinesOfCodeInFunction
sonar.issue.ignore.multicriteria.c17.resourceKey=**/*
# At most one statement is allowed per line, but 2 statements were found on this line.
sonar.issue.ignore.multicriteria.c18.ruleKey=c:TooManyStatementsPerLine
sonar.issue.ignore.multicriteria.c18.resourceKey=**/*
# parameter list has 9 parameters, which is greater than the 7 authorized.
sonar.issue.ignore.multicriteria.c19.ruleKey=c:TooManyParameters
sonar.issue.ignore.multicriteria.c19.resourceKey=**/*
# Undocumented API: hwloc_noos_component
sonar.issue.ignore.multicriteria.c20.ruleKey=c:UndocumentedApi
sonar.issue.ignore.multicriteria.c20.resourceKey=**/*
# Extra care should be taken to ensure that character arrays that are allocated on the stack are used safely. They are prime targets for buffer overflow attacks.
sonar.issue.ignore.multicriteria.r1.ruleKey=rats-c:fixed size global buffer
sonar.issue.ignore.multicriteria.r1.resourceKey=**/*
# A potential race condition vulnerability exists here. Normally a call to this function is vulnerable only when a match check precedes it. No check was detected, however one could still exist that could not be detected.
sonar.issue.ignore.multicriteria.r2.ruleKey=rats-c:fixed size local buffer
sonar.issue.ignore.multicriteria.r2.resourceKey=**/*
# Double check that your buffer is as big as you specify. When using functions that accept a number n of bytes to copy, such as strncpy, be aware that if the dest buffer size = n it may not NULL-terminate the string.sonar.issue.ignore.multicriteria.e8.ruleKey=rats:snprintf
sonar.issue.ignore.multicriteria.r3.ruleKey=rats-c:memcpy
sonar.issue.ignore.multicriteria.r3.resourceKey=**/*
# Don't use on memory intended to be secure, because the old structure will not be zeroed out
sonar.issue.ignore.multicriteria.r4.ruleKey=rats-c:realloc
sonar.issue.ignore.multicriteria.r4.resourceKey=**/*
# Double check that your buffer is as big as you specify. When using functions that accept a number n of bytes to copy, such as strncpy, be aware that if the dest buffer size = n it may not NULL-terminate the string.
sonar.issue.ignore.multicriteria.r5.ruleKey=rats-c:snprintf
sonar.issue.ignore.multicriteria.r5.resourceKey=**/*
# Check to be sure that the format string passed as argument 2 to this function call does not come from an untrusted source that could have added formatting characters that the code is not prepared to handle. Additionally, the format string could contain '%s' without precision that could result in a buffer overflow.
sonar.issue.ignore.multicriteria.r6.ruleKey=rats-c:sprintf
sonar.issue.ignore.multicriteria.r6.resourceKey=**/*
# This function does not properly handle non-NULL terminated strings. This does not result in exploitable code, but can lead to access violations.
sonar.issue.ignore.multicriteria.r7.ruleKey=rats-c:strlen
sonar.issue.ignore.multicriteria.r7.resourceKey=**/*
EOF

# Run the sonar-scanner analysis and submit to SonarQube server
Expand Down

0 comments on commit e11730a

Please sign in to comment.