This repository was archived by the owner on Sep 30, 2022. It is now read-only.
mpool/udreg: manual patch to use mntent #1298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
| #elif defined(HAVE_STATVFS) | ||
| struct statvfs info; | ||
| statvfs (mntent->mnt_dir, &info); | ||
| page_size = info.f_bsize; |
There was a problem hiding this comment.
Setting the page_size variable needs to happen outside the #if region.
|
One minor bug but otherwise good to go. Let me know when it is fixed and I will mark as reviewed. |
This is a hand-coded patch to udreg mpool component to use the mntent interface to parse /proc/mounts entries. Needed for XC/KNL-xeons running CLE 6 or higher because, depending on use of images at customer site, there may be some very large entries in /proc/mounts which broke the original parsing code, leading to failure to launch, segfaults, etc. Signed-off-by: Howard Pritchard <howardp@lanl.gov>
hppritcha
force-pushed
the
topic/mntent_mpool_fixes
branch
from
6643518 to
3912271
Compare
|
@hjelmn I fixed it 😃 |
|
Test PASSed. |
|
@hjelmn please review again |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hand-coded patch to udreg mpool
component to use the mntent interface to
parse /proc/mounts entries.
Needed for XC/KNL-xeons running CLE 6
or higher because, depending on use of images
at customer site, there may be some very large
entries in /proc/mounts which broke the original
parsing code, leading to failure to launch, segfaults,
etc.
@hjelmn
Signed-off-by: Howard Pritchard howardp@lanl.gov