This repository was archived by the owner on Sep 30, 2022. It is now read-only.
Update the session directory code to no longer rely on getpwuid as it is unnecessary. #1320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is unnecessary. Fixes open-mpi/ompi#1964
|
Test FAILed. |
|
Test FAILed. |
|
hmmm, looks like mpirun can't work on a stock cluster. let's retry |
|
bot:mellanox:retest |
|
Test FAILed. |
|
Test FAILed. |
|
This PR causes both mlnx and UH hello worlds to hang. |
|
bot:lanl:retest |
|
Test FAILed. |
|
@rhc54 Are there follow-on commits that should be added to this PR? (e.g., based on further activity in master, e.g., per open-mpi/ompi#1967 and open-mpi/ompi#1968 and open-mpi/ompi#1971)? |
|
No - this PR isn't actually required any more. The rsh update is all that is needed to solve the problem, and is the minimal change required. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-mpi/ompi#1964