This repository was archived by the owner on Sep 30, 2022. It is now read-only.
opal_check_portals.m4: remove this unused file #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like OPAL_CHECK_PORTALS is not used anywhere; it looks like it has been completely replaced by opal_check_portals4.m4 (OPAL_CHECK_PORTALS4). (cherry picked from commit open-mpi/ompi@225c684)
Member
|
Looks good. 👍 |
Member
Author
|
@tkordenbrock Hah! I didn't know about the "thumbsup" version of the emoticon. If you do the "+1", version, the bot will add the "reviewed" label, and it uses the same emoticon as "thumbsup". Like this: 👍 (I'll go add "thumbsup" to the bot's vocabulary...) |
Member
|
@jsquyres Ahh. I guess that explains why the auto-complete suggested "+1" as I was typing "thumbsup". |
Member
Author
rhc54
pushed a commit
that referenced
this pull request
Aug 20, 2015
opal_check_portals.m4: remove this unused file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like OPAL_CHECK_PORTALS is not used anywhere; it looks like it has been completely replaced by opal_check_portals4.m4 (OPAL_CHECK_PORTALS4).
(cherry picked from commit open-mpi/ompi@225c684)
@regrant @tkordenbrock please confirm that this removal is ok. I committed this on master in Nov 2014 -- looks like it never made it over to v1.8 (and therefore didn't make it to v1.10).